Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename useRenderTooltipContent to getTooltipContentRenderer #1637

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

envex
Copy link
Collaborator

@envex envex commented Mar 11, 2024

What does this implement/fix?

useRenderTooltipContent no longer needs to be a hook so we can rename it to remove the use terminology.

This also fixes an issue in web where we were renaming the import to get around linting rules.

Does this close any currently open issues?

Resolves #1632

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

@envex envex requested a review from rita-morozova March 11, 2024 19:49
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.36 KB (0%) 1.3 s (0%) 1.2 s (+95.26% 🔺) 2.5 s
polaris-viz-cjs 215.5 KB (-0.23% 🔽) 4.4 s (-0.23% 🔽) 2 s (+14.9% 🔺) 6.3 s
polaris-viz-esm 175.92 KB (-0.02% 🔽) 3.6 s (-0.02% 🔽) 1.6 s (+9.4% 🔺) 5.1 s
polaris-viz-css 4.78 KB (0%) 96 ms (0%) 269 ms (+1.16% 🔺) 365 ms
polaris-viz-esnext 181.82 KB (+0.22% 🔺) 3.7 s (+0.22% 🔺) 1.2 s (-8.54% 🔽) 4.9 s

@envex envex merged commit 0f67c1f into main Mar 12, 2024
6 checks passed
@envex envex deleted the envex/tooltip-renderer branch September 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor useRenderTooltipContent and export
2 participants