Implement design changes to LineChartRelational #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
envex
force-pushed
the
envex/line-chart-relational-changes
branch
from
82d1eac to
2712166
Compare
rita-morozova
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Implementing design changes to
LineChartRelational.<Legend />to render a single item.styleOverride.tooltipproperty to render different shapes inrenderLinearTooltipContent().Resolves https://github.com/Shopify/core-issues/issues/68245, https://github.com/Shopify/core-issues/issues/68244 & https://github.com/Shopify/core-issues/issues/68246
Note
We are not implementing the centered
<Legend />changes in this PR.What do the changes look like?
Storybook link
https://6062ad4a2d14cd0021539c1b-zeeikswiqb.chromatic.com/?path=/story/polaris-viz-charts-linechartrelational--default
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package