Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate delay based on item count #1654

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Generate delay based on item count #1654

merged 1 commit into from
Apr 4, 2024

Conversation

envex
Copy link
Collaborator

@envex envex commented Apr 3, 2024

What does this implement/fix?

Make the animation delay for <DonutChart /> based on the slice count so larger data sets animate in faster.

Does this close any currently open issues?

https://github.com/Shopify/core-issues/issues/68903

Storybook link

https://6062ad4a2d14cd0021539c1b-thyldzcwtk.chromatic.com/?path=/story/polaris-viz-charts-donutchart-playground--animation-speed

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

@envex envex force-pushed the envex/donut-delay branch from 78cb680 to b027f31 Compare April 3, 2024 21:13
Copy link

github-actions bot commented Apr 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.36 KB (0%) 1.3 s (0%) 904 ms (-7.31% 🔽) 2.2 s
polaris-viz-cjs 215.96 KB (+0.04% 🔺) 4.4 s (+0.04% 🔺) 1.7 s (-3.46% 🔽) 6 s
polaris-viz-esm 176.29 KB (+0.02% 🔺) 3.6 s (+0.02% 🔺) 1.4 s (+7.34% 🔺) 4.9 s
polaris-viz-css 4.79 KB (0%) 96 ms (0%) 222 ms (-4.48% 🔽) 318 ms
polaris-viz-esnext 182.28 KB (+0.02% 🔺) 3.7 s (+0.02% 🔺) 1.3 s (+2.08% 🔺) 4.9 s

@envex envex requested a review from michaelnesen April 4, 2024 13:56
Copy link
Collaborator

@michaelnesen michaelnesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee 👏

@envex envex merged commit 9bc8903 into main Apr 4, 2024
6 checks passed
@envex envex deleted the envex/donut-delay branch September 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants