Change default theme to Light theme #1658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
web
currently usesUplift
as the current default theme, butpolaris-viz
defaults to the olderDark/Default
theme.We have an issue where if consumers in web don't correctly use the
PolarisVizProvider
the charts render theDark/Default
theme.We're going to merge
Uplift
into theLight
theme and change the default toLight
instead ofDark/Default
.Web PR: https://github.com/Shopify/web/pull/123949
What do the changes look like?
All the charts should render with the
Light
theme instead of them all beingDark
.web
: https://admin.web.polaris-viz-light-default.matthew-vickers.us.spin.dev/store/shop1/dashboardsStorybook link
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package