Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default theme to Light theme #1658

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Change default theme to Light theme #1658

merged 2 commits into from
Apr 15, 2024

Conversation

envex
Copy link
Collaborator

@envex envex commented Apr 12, 2024

What does this implement/fix?

web currently uses Uplift as the current default theme, but polaris-viz defaults to the older Dark/Default theme.

We have an issue where if consumers in web don't correctly use the PolarisVizProvider the charts render the Dark/Default theme.

We're going to merge Uplift into the Light theme and change the default to Light instead of Dark/Default.

Web PR: https://github.com/Shopify/web/pull/123949

What do the changes look like?

All the charts should render with the Light theme instead of them all being Dark.

web: https://admin.web.polaris-viz-light-default.matthew-vickers.us.spin.dev/store/shop1/dashboards

Storybook link

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

Copy link

github-actions bot commented Apr 12, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.27 KB (-0.16% 🔽) 1.3 s (-0.16% 🔽) 941 ms (-1.96% 🔽) 2.2 s
polaris-viz-cjs 216.06 KB (-0.05% 🔽) 4.4 s (-0.05% 🔽) 1.8 s (+9.04% 🔺) 6.2 s
polaris-viz-esm 176.37 KB (-0.05% 🔽) 3.6 s (-0.05% 🔽) 1.9 s (-4.73% 🔽) 5.4 s
polaris-viz-css 4.79 KB (0%) 96 ms (0%) 333 ms (-2.83% 🔽) 428 ms
polaris-viz-esnext 182.31 KB (-0.08% 🔽) 3.7 s (-0.08% 🔽) 1.6 s (-0.28% 🔽) 5.2 s

@envex envex force-pushed the envex/light-mode-default branch from 6773984 to 430c187 Compare April 12, 2024 19:55
@envex envex force-pushed the envex/light-mode-default branch from 430c187 to 3345f08 Compare April 12, 2024 20:42
@envex envex marked this pull request as ready for review April 12, 2024 21:01
Copy link
Collaborator

@michaelnesen michaelnesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🫡

@envex envex merged commit 0b0bb71 into main Apr 15, 2024
6 checks passed
@envex envex deleted the envex/light-mode-default branch September 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants