Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remount RelatedAreas when data changes #1667

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

envex
Copy link
Collaborator

@envex envex commented May 24, 2024

What does this implement/fix?

Remount <RelatedAreas /> when the data changes.

Resolves https://github.com/Shopify/core-issues/issues/71032#issuecomment-2129763962

Storybook link

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

@envex envex force-pushed the envex/remount-related-areas branch from 1a96337 to 11671eb Compare May 24, 2024 15:39
@envex envex marked this pull request as ready for review May 24, 2024 15:41
@envex envex requested a review from blboyle May 24, 2024 15:41
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.18 KB (0%) 1.3 s (0%) 848 ms (-2.47% 🔽) 2.1 s
polaris-viz-cjs 216.17 KB (-0.02% 🔽) 4.4 s (-0.02% 🔽) 1.8 s (+0.28% 🔺) 6.1 s
polaris-viz-esm 176.5 KB (+0.01% 🔺) 3.6 s (+0.01% 🔺) 1.5 s (+2.52% 🔺) 5 s
polaris-viz-css 4.79 KB (0%) 96 ms (0%) 246 ms (-20.39% 🔽) 342 ms
polaris-viz-esnext 182.42 KB (+0.01% 🔺) 3.7 s (+0.01% 🔺) 1.3 s (+1.53% 🔺) 5 s

Copy link
Contributor

@blboyle blboyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@envex envex merged commit dbae7a0 into main May 27, 2024
6 checks passed
@envex envex deleted the envex/remount-related-areas branch September 12, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants