Stop double formatting in label calculation #1786
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Fixes double formatting and inaccurate measuring in the Donut Chart
Does this close any currently open issues?
Should fix https://github.com/Shopify/web/issues/152100 once updated in web
What do the changes look like?
You can see below in the console that the string we were measuring double formatted the label. You can see that as a result, the container was larger than it needed to be.
After, the container is the correct size, and you can see in the console that the string being measured is not double formatted.
Storybook link
I haven't added a story for this, but you can try it out on the existing donut chart stories by console.logging the label that is getting measured here
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package