Fix tooltip overflow when displaying long title without space #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envex
reviewed
Jan 30, 2025
packages/polaris-viz/src/components/TooltipContent/stories/LongTitleWithoutSpace.stories.tsx
Outdated
Show resolved
Hide resolved
AnhVu23
force-pushed
the
fix-tooltip-overflow
branch
from
d0bfc3a to
6d25507
Compare
envex
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
When displaying long tooltip title without space, the text is overflow. More details and the bug reproduction are mentioned here: #1787.
PR aims to fix the issue by adding overflow-wrap: break-word to the
<TooltipTitle />component.Does this close any currently open issues?
Issue link: #1787.
What do the changes look like?
Storybook link
I created a new storybook for this case, but I do not know how to add remote url. Here is the local url: http://localhost:6006/?path=/story/polaris-viz-subcomponents-tooltipcontent--long-title-without-space
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package