Use a portal for horizontal tooltips #1797
Open
+89
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envex
force-pushed
the
envex/horizontal-portal-tooltips
branch
from
dad039b to
2f46506
Compare
envex
commented
Jan 31, 2025
| }); | ||
|
|
There was a problem hiding this comment.
Now that we're rendering in a portal, we only care if the tooltip stays within the bounds of the browser window, not the chart itself.
size-limit report 📦
|
envex
force-pushed
the
envex/horizontal-portal-tooltips
branch
from
2f46506 to
cd80b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
As part of the UX tooltip audit, we want to enable tooltips on every chart. In order to add tooltips to the
SimpleBarChartwe needed theHorizontalBarChartto render it's tooltip in a portal.Does this close any currently open issues?
Storybook link
Before merging
Check your changes on a variety of browsers and devices.
Update the Changelog's Unreleased section with your changes.
Update relevant documentation, tests, and Storybook.
Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package