Skip to content

Commit

Permalink
Update button migration examples (#10903)
Browse files Browse the repository at this point in the history
### WHY are these changes introduced?

Adds an example of what's to be expected when migrating a `<Button
primary plain monochrome />` element. I don't think we don't want to
default to a new style, like `plain monochrome` which might be the
safest, because consumers may want to opt for the `plain` variant.

So we just insert a comment and defer to the team / section responsible
  • Loading branch information
kyledurand authored and mrcthms committed Oct 12, 2023
1 parent 0f52850 commit bb15d33
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ export function App() {
<Button monochrome plain>
Edit
</Button>
<Button monochrome plain primary>
Edit
</Button>
<Button plain monochrome={isPolarisUplift}>
Edit
</Button>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ export function App() {
<Button variant="monochromePlain">Edit</Button>
<Button variant="monochromePlain">Edit</Button>
{/* polaris-migrator: Unable to migrate the following expression. Please upgrade manually. */}
<Button monochrome plain primary>
Edit
</Button>
{/* polaris-migrator: Unable to migrate the following expression. Please upgrade manually. */}
<Button plain monochrome={isPolarisUplift}>
Edit
</Button>
Expand Down

0 comments on commit bb15d33

Please sign in to comment.