Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[polaris.shopify.com] Add border to images #10907

Closed
johanstromqvist opened this issue Oct 5, 2023 · 0 comments · Fixed by #10939
Closed

[polaris.shopify.com] Add border to images #10907

johanstromqvist opened this issue Oct 5, 2023 · 0 comments · Fixed by #10939
Assignees
@kyledurand

Comments

@johanstromqvist
Copy link
Contributor

Images of UI blend with doc site card bg, making it hard to distinguish which is what.

Image

Image
@kyledurand kyledurand self-assigned this Oct 10, 2023
@kyledurand kyledurand mentioned this issue Oct 10, 2023
Merged
kyledurand added a commit that referenced this issue Oct 10, 2023
@kyledurand
[polaris.shopify.com] Add borders to images (#10939)
5238c36 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #10907


![image](https://github.com/Shopify/polaris/assets/6844391/ccb6e5ef-0d40-49aa-8800-0047c33ad216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyledurand kyledurand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[polaris.shopify.com] Add borders to images Shopify/polaris
2 participants
@kyledurand @johanstromqvist