Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[polaris.shopify.com] Add borders to images #10939

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[polaris.shopify.com] Add borders to images #10939

merged 1 commit into from
Oct 10, 2023

Conversation

kyledurand
Copy link
Member

@kyledurand kyledurand commented Oct 10, 2023 •
edited
Loading

WHY are these changes introduced?

Fixes #10907

image

@kyledurand kyledurand changed the base branch from next to main October 10, 2023 15:38
@kyledurand kyledurand added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Oct 10, 2023
johanstromqvist
johanstromqvist approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@johanstromqvist johanstromqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kyledurand kyledurand merged commit 5238c36 into main Oct 10, 2023
@kyledurand kyledurand deleted the add-borders-to-images branch October 10, 2023 15:52
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this pull request Apr 22, 2024
@kyledurand
[polaris.shopify.com] Add borders to images (Shopify#10939)
3c96e8f 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes Shopify#10907


![image](https://github.com/Shopify/polaris/assets/6844391/ccb6e5ef-0d40-49aa-8800-0047c33ad216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanstromqvist johanstromqvist johanstromqvist approved these changes

Assignees
No one assigned
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[polaris.shopify.com] Add border to images
2 participants
@kyledurand @johanstromqvist