-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ChoiceList
mobile styles
#11896
Update ChoiceList
mobile styles
#11896
Conversation
/snapit |
🫰✨ Thanks @lgriffee! Your snapshothas been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20240416230446" |
97475fd
to
d96cdb0
Compare
d96cdb0
to
243caa8
Compare
97475fd
to
fab4bbd
Compare
fab4bbd
to
6af762a
Compare
6af762a
to
0ac65ae
Compare
ChoiceList
mobile stylesChoiceList
mobile styles
0ac65ae
to
f07e1b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just one question about the indentation of the children
content, I noticed it's updated to now be in line with the radio button, is that intentional? I didn't see an example in the Figma.
@aveline Yes, it was an intentional change based on these mockups in Figma. Would be good to confirm with @heyjoethomas this is still the desired design update! |
Closing in favor of build phase PR |
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-internal/issues/1590
Fixes https://github.com/Shopify/mobile/issues/33785
Caution
Basing this PR off of #11837 and will not merge until that ships. No need to include changes from #11878 since the helper/error text changes do not factor into clickable area.
WHAT is this pull request doing?
Choice
padding so the tap target on mobile is 48pxChoiceList
mobile paddingHow to 🎩
Tip
Make sure you have the breakpoint in storybook at
sm
orxs
to see the changes!