Align RadioButton styles with mobile
#11840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-b-rose
reviewed
Apr 5, 2024
Closed
lgriffee
changed the title
border-width for improved mobile consistencyRadioButton border-width for improved mobile consistency
lgriffee
changed the title
RadioButton border-width for improved mobile consistencyRadioButton styles with mobile
lgriffee
force-pushed
the
radio-button-mobile-alignment
branch
from
28cb9ea to
3f5a361
Compare
aaronccasanova
force-pushed
the
radio-button-mobile-alignment
branch
from
3f5a361 to
7f0a868
Compare
github-actions
bot
added
the
cla-needed
lgriffee
force-pushed
the
radio-button-mobile-alignment
branch
from
7f0a868 to
ffcea19
Compare
github-actions
bot
removed
the
cla-needed
lgriffee
force-pushed
the
radio-button-mobile-alignment
branch
from
ffcea19 to
be0756e
Compare
lgriffee
changed the title
RadioButton styles with mobileRadioButton styles with mobile
sam-b-rose
approved these changes
May 7, 2024
|
Closing in favor of build phase PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-internal/issues/1578
Fixes https://github.com/Shopify/mobile/issues/33784
Caution
Basing this PR off of #11896 (which is also based off #11837) and will not merge until that ships. This PR does not include changes from #11878 so you will not see the updates to the helper/error text size.
WHAT is this pull request doing?
border-widthof radio buttons belowbreakpoint-mdfrom0.66px➡️1pxbreakpoint-mdfrom18px➡️20px(this is done by removing a margin so it will not shift any layouts since it takes up the same amount of space it did before)Tip
Make sure you have the breakpoint in storybook at
smorxsto see the changes!