[CalloutCard] Fix dismiss button UI inconsistencies #12967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @moraleslevi! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20241204173342" |
moraleslevi
force-pushed
the
moraleslevi/banner-icon
branch
from
48a678e to
b80a0a8
Compare
moraleslevi
changed the title
XSMallIcon for Banner dismiss buttonCalloutCard UI consistency
moraleslevi
changed the title
CalloutCard UI consistencyCalloutCard UI inconsistency
moraleslevi
changed the title
CalloutCard UI inconsistencyCalloutCard dismiss button inconsistencies
moraleslevi
force-pushed
the
moraleslevi/banner-icon
branch
from
b80a0a8 to
f8ee15b
Compare
|
/snapit |
|
🫰✨ Thanks @moraleslevi! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/polaris": "0.0.0-snapshot-20241204202554" |
moraleslevi
changed the title
CalloutCard dismiss button inconsistencies
aveline
approved these changes
Dec 16, 2024
Merged
moraleslevi
pushed a commit
that referenced
this pull request
Dec 18, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Patch Changes - [#12967](#12967) [`50246bbbd0455c30c6950b08c93ac7f7d1811fc0`](50246bb) Thanks [@moraleslevi](https://github.com/moraleslevi)! - CalloutCard dismiss button improvements: - Use tertiary button variant - Use regular sized X icon - Adjust position to match Banner - Add translated label ## [email protected] ### Patch Changes - Updated dependencies \[[`50246bbbd0455c30c6950b08c93ac7f7d1811fc0`](50246bb)]: - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #12968
The dismiss button on the CalloutCard does not match the UI of the dismiss button on the Banner, which is very apparent when the components are rendered near each other.
WHAT is this pull request doing?
This makes four changes to the CalloutCard dismiss button:
Before
After
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes