Merge pull request #288 from Shopify/ko/bump-spoom

Bump spoom to v1.5.0
Shopify · Sep 30, 2024 · 365f21b · 365f21b
2 parents e7e03ce + 1dd97c6
commit 365f21b
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 36 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -55,15 +55,15 @@ GEM
     rubocop-sorbet (0.8.5)
       rubocop (>= 1)
     ruby-progressbar (1.13.0)
-    sorbet (0.5.11585)
-      sorbet-static (= 0.5.11585)
-    sorbet-runtime (0.5.11585)
-    sorbet-static (0.5.11585-universal-darwin)
-    sorbet-static (0.5.11585-x86_64-linux)
-    sorbet-static-and-runtime (0.5.11585)
-      sorbet (= 0.5.11585)
-      sorbet-runtime (= 0.5.11585)
-    spoom (1.4.2)
+    sorbet (0.5.11589)
+      sorbet-static (= 0.5.11589)
+    sorbet-runtime (0.5.11589)
+    sorbet-static (0.5.11589-universal-darwin)
+    sorbet-static (0.5.11589-x86_64-linux)
+    sorbet-static-and-runtime (0.5.11589)
+      sorbet (= 0.5.11589)
+      sorbet-runtime (= 0.5.11589)
+    spoom (1.5.0)
       erubi (>= 1.10.0)
       prism (>= 0.28.0)
       sorbet-static-and-runtime (>= 0.5.10187)

diff --git a/gem/Gemfile.lock b/gem/Gemfile.lock
@@ -77,15 +77,15 @@ GEM
     rubocop-sorbet (0.8.5)
       rubocop (>= 1)
     ruby-progressbar (1.13.0)
-    sorbet (0.5.11553)
-      sorbet-static (= 0.5.11553)
-    sorbet-runtime (0.5.11553)
-    sorbet-static (0.5.11553-universal-darwin)
-    sorbet-static (0.5.11553-x86_64-linux)
-    sorbet-static-and-runtime (0.5.11553)
-      sorbet (= 0.5.11553)
-      sorbet-runtime (= 0.5.11553)
-    spoom (1.4.2)
+    sorbet (0.5.11589)
+      sorbet-static (= 0.5.11589)
+    sorbet-runtime (0.5.11589)
+    sorbet-static (0.5.11589-universal-darwin)
+    sorbet-static (0.5.11589-x86_64-linux)
+    sorbet-static-and-runtime (0.5.11589)
+      sorbet (= 0.5.11589)
+      sorbet-runtime (= 0.5.11589)
+    spoom (1.5.0)
       erubi (>= 1.10.0)
       prism (>= 0.28.0)
       sorbet-static-and-runtime (>= 0.5.10187)

diff --git a/gem/lib/rbi-central/context.rb b/gem/lib/rbi-central/context.rb
@@ -84,7 +84,9 @@ def add_gem_dependency(name, version: nil, github: nil, branch: nil, ref: nil, p
 
     sig { params(gem_name: String, annotations_file: String).returns(String) }
     def filter_versions_from_annotation(gem_name, annotations_file)
-      gem_version = ::Gem::Version.new(gem_version_from_gemfile_lock(gem_name))
+      gem_version = gem_version_from_gemfile_lock(gem_name)
+      raise Error, "Can't find version for gem `#{gem_name}`" unless gem_version
+
       rbi = RBI::Parser.parse_file(annotations_file)
       rbi.filter_versions!(gem_version)
 

diff --git a/gem/sorbet/rbi/gems/[email protected] → gem/sorbet/rbi/gems/[email protected] b/gem/sorbet/rbi/gems/[email protected] → gem/sorbet/rbi/gems/[email protected]