Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type zone and current methods in Time #259

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Type zone and current methods in Time #259

merged 1 commit into from
Jul 8, 2024

Conversation

ipvalverde
Copy link
Contributor

@ipvalverde ipvalverde commented Jun 28, 2024 •
edited
Loading

Type of Change

  • Add RBI for a new gem
  • Modify RBI for an existing gem
  • Other:

Changes

  • Gem name: activesupport
  • Gem version:
  • Gem source:
  • Gem API doc: Time.current and Time.zone
  • Tapioca version:
  • Sorbet version:

@ipvalverde ipvalverde force-pushed the iv/type-time-class-methods branch from 25fc090 to 282f5e7 Compare June 28, 2024 18:39
@ipvalverde ipvalverde marked this pull request as ready for review June 28, 2024 19:11
@ipvalverde ipvalverde requested a review from a team as a code owner June 28, 2024 19:11
@ipvalverde ipvalverde force-pushed the iv/type-time-class-methods branch from 282f5e7 to 8e852e5 Compare July 8, 2024 12:34
@egiurleo egiurleo merged commit 43b102b into main Jul 8, 2024
5 checks passed
@egiurleo egiurleo deleted the iv/type-time-class-methods branch July 8, 2024 16:34
@jshirley jshirley mentioned this pull request Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egiurleo egiurleo egiurleo approved these changes

@Morriar Morriar Awaiting requested review from Morriar Morriar is a code owner automatically assigned from Shopify/sorbet

@amomchilov amomchilov Awaiting requested review from amomchilov amomchilov is a code owner automatically assigned from Shopify/sorbet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipvalverde @egiurleo