Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ErrorReporter unexpected method #264

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Add ErrorReporter unexpected method #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions rbi/annotations/activesupport.rbi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,4 +493,15 @@ class ActiveSupport::ErrorReporter
).void
end
def report(error, handled: true, severity: T.unsafe(nil), context: T.unsafe(nil), source: T.unsafe(nil)); end

# @version >= 7.2.0.beta1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you win the award for the very first version annotation? 🥇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we want to handle runtime checks? I think CI will use the latest version however beta versions can only be specified in the Gemfile?

There's also the case of annotations with an incompatible version, < 7.2.0beta1. Should we just use @method_missing instead of dealing with this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to think more about this today

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is fine thanks to Shopify/tapioca#1585 but I'll leave it to @egiurleo before merging. We may wanna test versioning with apps that use lower Rails versions as we merge this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah let's merge this and I'll add a note to our meeting on Monday to talk about it.

sig do
params(
error: T.any(Exception, String),
severity: T.nilable(Symbol),
context: T::Hash[Symbol, T.untyped],
source: T.nilable(String),
).void
end
def unexpected(error, severity: T.unsafe(nil), context: T.unsafe(nil), source: T.unsafe(nil)); end
end
Loading