Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully qualify JITTER_DEFAULT constant #291

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fully qualify JITTER_DEFAULT constant #291

merged 1 commit into from
Oct 25, 2024

Conversation

mmenanno
Copy link
Contributor

Type of Change

  • Add RBI for a new gem
  • Modify RBI for an existing gem
  • Other:

Changes

When I was initializing a new repo, a todo.rb file was being created for this constant, looks like it needs to be fully qualified to not cause an issue.

@mmenanno mmenanno requested a review from a team as a code owner October 25, 2024 03:29
@mmenanno mmenanno requested review from andyw8 and KaanOzkan October 25, 2024 03:29
@mmenanno mmenanno changed the title fully qualify DEFAULT_JITTER constant fully qualify JITTER_DEFAULT constant Oct 25, 2024
@KaanOzkan KaanOzkan merged commit 12386e5 into Shopify:main Oct 25, 2024
4 checks passed
@mmenanno mmenanno deleted the default-jitter-fix branch October 25, 2024 14:37
@amomchilov amomchilov changed the title fully qualify JITTER_DEFAULT constant Fully qualify JITTER_DEFAULT constant Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan approved these changes

@andyw8 andyw8 Awaiting requested review from andyw8 andyw8 is a code owner automatically assigned from Shopify/sorbet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmenanno @KaanOzkan