Add annotation for before and after for Minitest::HooksSpec
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
force-pushed
the
andyw8/add-annotation-for-minitest-afer
branch
3 times, most recently
from
56e2869 to
eb10792
Compare
andyw8
changed the title
after for Minitest::Specafter for Minitest::HooksSpec
andyw8
force-pushed
the
andyw8/add-annotation-for-minitest-afer
branch
7 times, most recently
from
ccc7e10 to
dcd6d74
Compare
andyw8
force-pushed
the
andyw8/add-annotation-for-minitest-afer
branch
from
dcd6d74 to
9ed8dcd
Compare
KaanOzkan
reviewed
Feb 3, 2025
| class Minitest::HooksSpec | ||
| sig { params(arg: Symbol, block: T.proc.bind(T.attached_class).void).void } | ||
| def self.after(arg, &block); end | ||
| end |
There was a problem hiding this comment.
Can you link the source in PR description, is it https://github.com/jeremyevans/minitest-hooks/blob/332e0bc69c811ae8dbc4c1c9d7c744da786585d6/lib/minitest/hooks/test.rb#L125-L135?
There was a problem hiding this comment.
I think this originally came from a comment by Vini, but I've updated it to better match the implementation.
andyw8
force-pushed
the
andyw8/add-annotation-for-minitest-afer
branch
from
9ed8dcd to
829e101
Compare
vinistock
reviewed
Feb 3, 2025
andyw8
force-pushed
the
andyw8/add-annotation-for-minitest-afer
branch
from
829e101 to
85a61aa
Compare
|
Added |
vinistock
approved these changes
Feb 3, 2025
andyw8
changed the title
after for Minitest::HooksSpecbefore and after for Minitest::HooksSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
(this is from the minitest-hooks gem, not minitest itself)
https://github.com/jeremyevans/minitest-hooks/blob/332e0bc69c811ae8dbc4c1c9d7c744da786585d6/lib/minitest/hooks/test.rb#L125-L135