Fix Float32Array check

Shopify · Jan 17, 2024 · 7d41178 · 7d41178
1 parent cad5a03
commit 7d41178
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/package/cpp/api/JsiSkColor.h b/package/cpp/api/JsiSkColor.h
@@ -77,9 +77,7 @@ class JsiSkColor : public RNJsi::JsiHostObject {
             runtime, SkColorSetARGB(color.a * 255, color.r, color.g, color.b));
       } else if (arguments[0].isObject()) {
         auto obj = arguments[0].getObject(runtime);
-        if (obj.isArrayBuffer(runtime)) {
-          return obj;
-        } else if (obj.isArray(runtime)) {
+        if (obj.isArray(runtime)) {
           auto array = obj.asArray(runtime);
           double r = std::clamp(array.getValueAtIndex(runtime, 0).getNumber(),
                                 0.0, 255.0);
@@ -90,6 +88,8 @@ class JsiSkColor : public RNJsi::JsiHostObject {
           double a = std::clamp(array.getValueAtIndex(runtime, 3).getNumber(),
                                 0.0, 255.0);
           return JsiSkColor::toValue(runtime, SkColorSetARGB(a, r, g, b));
+        } else if (obj.hasProperty(runtime, jsi::PropNameID::forAscii(runtime, "buffer"))) {
+          return obj;
         }
       }
       return jsi::Value::undefined();