fix bug in documentation building (#2620)

Shopify · Sep 10, 2024 · 8b4581c · 8b4581c
1 parent d51beb3
commit 8b4581c
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 12 deletions.
diff --git a/.github/workflows/build-npm.yml b/.github/workflows/build-npm.yml
@@ -25,18 +25,17 @@ jobs:
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
 
+      - name: Build package and documentation
+        run: yarn build
+
       - name: Build NPM Package
         working-directory: packages/skia
         run: |
-          yarn build
           npx semantic-release
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
 
-      - name: Install & Build Docs
-        run: cd apps/docs; yarn build;
-
       - name: Deploy to GitHub Pages
         uses: peaceiris/actions-gh-pages@v3
         with:

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -74,6 +74,14 @@ jobs:
       - name: Build package
         run: yarn build
 
+      - name: Build dry run release
+        working-directory: packages/skia
+        run: |
+          npx semantic-release --dry-run
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
+
   build-android-ubuntu:
     runs-on: ubuntu-latest
     continue-on-error: true

diff --git a/apps/docs/package.json b/apps/docs/package.json
@@ -19,7 +19,7 @@
     "@docusaurus/core": "2.4.3",
     "@docusaurus/preset-classic": "2.4.3",
     "@mdx-js/react": "^1.6.21",
-    "@shopify/react-native-skia": "link:../package/",
+    "@shopify/react-native-skia": "workspace:*",
     "@svgr/webpack": "^5.5.0",
     "clsx": "^1.1.1",
     "docusaurus-preset-shiki-twoslash": "1.1.41",

diff --git a/yarn.lock b/yarn.lock
@@ -3721,12 +3721,6 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@shopify/react-native-skia@link:../package/::locator=docs%40workspace%3Aapps%2Fdocs":
-  version: 0.0.0-use.local
-  resolution: "@shopify/react-native-skia@link:../package/::locator=docs%40workspace%3Aapps%2Fdocs"
-  languageName: node
-  linkType: soft
-
 "@shopify/react-native-skia@workspace:*, @shopify/react-native-skia@workspace:packages/skia":
   version: 0.0.0-use.local
   resolution: "@shopify/react-native-skia@workspace:packages/skia"
@@ -7734,7 +7728,7 @@ __metadata:
     "@docusaurus/module-type-aliases": 2.4.3
     "@docusaurus/preset-classic": 2.4.3
     "@mdx-js/react": ^1.6.21
-    "@shopify/react-native-skia": "link:../package/"
+    "@shopify/react-native-skia": "workspace:*"
     "@svgr/webpack": ^5.5.0
     "@tsconfig/docusaurus": ^1.0.4
     clsx: ^1.1.1