Bugfix(android): dynamic pixel density change

[kedikx]

This is a fix for #2635.

Summary:

• PlatformContext: implement get/set pixel density methods, set/update current density from ReactContext on resume.

• RNSkAndroidPlatformContext: reuse getPixelDensity() from jniContext instead on base member variable.

[wcandillon]

Thanks a lot, can you recommend me a way to test the pixel density change? Is this an issue on iOS as well?

[kedikx]

Thanks a lot, can you recommend me a way to test the pixel density change?

Link to repo/app I used to spot the problem and test the solution.
https://github.com/kedikx/rns-density

I also had a plan to add case to app/paper or dedicated app/density, but suppose it will be another story.
#2635 also have the video for use case.

Is this an issue on iOS as well?

I am not aware of possibility to change density on iOS.
Never saw it, at least from a user point of view.

[kedikx]

I have signed the CLA!

[kedikx]

can you recommend me a way to test the pixel density change?

General idea:

You need a random case where canvas and it's content depends on container size (i.e. "button skin").

Steps:

1. Get canvas on the screen and check image - it should look like expected by design.
2. Go to Android Settings -> Display -> Display size & text -> Change "Display Size".
3. Go back to App: In case of problem: canvas size will change (could be verified with Fill), but "skin" will not be resized: it will either smaller or bigger than the container. Otherwise, it should look similar to (1) but shrink/expand together with container.

NB!:
/android/app/src/main/AndroidManifest.xml should have 'density' in configChanges
(fontScale also if you want to get things even more complicated):

android:configChanges="...|density|fontScale|..."

[wcandillon]

@kedikx Sorry it took me so much time to get back to you on this. The reason I was a bit silent on this is that where were doing refactoring where we thought the problem would be addressed differently. But indeed this is makes sense and I am now looking to merge this change.

[wcandillon]

should this be "onConfigurationChanged"?