Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant rescue in runner client #528

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Remove redundant rescue in runner client #528

merged 1 commit into from
Nov 19, 2024
+1 −1

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Nov 19, 2024

Errno::ENOENT already inherits from StandardError, so there is no need to rescue it explicitly

> Errno::ENOENT.new.is_a?(StandardError)
=> true

@andyw8 andyw8 added the chore Chore task label Nov 19, 2024
@andyw8 andyw8 requested a review from a team as a code owner November 19, 2024 14:43
@andyw8 andyw8 changed the title Remove redundant rescue Remove redundant rescue in runner client Nov 19, 2024
@andyw8 andyw8 force-pushed the andyw8/remove-redundant-rescue branch from 556867e to a0d475d Compare November 19, 2024 14:50
@andyw8 andyw8 enabled auto-merge (squash) November 19, 2024 14:51
@andyw8 andyw8 merged commit 106c397 into main Nov 19, 2024
28 checks passed
@andyw8 andyw8 deleted the andyw8/remove-redundant-rescue branch November 19, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

Assignees
No one assigned
Labels
chore Chore task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @vinistock