Skip to content

Add support for :through associations #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshuay03
Copy link

Currently, clicking on the through association name goes to the same file as the association name. I've added explicit support to navigate to the correct through association model file.

@joshuay03 joshuay03 requested a review from a team as a code owner July 3, 2025 14:09
@joshuay03 joshuay03 force-pushed the through-association-support branch from de3a801 to 62c54e5 Compare July 3, 2025 14:10
@joshuay03 joshuay03 changed the title Add support for :through associations Add support for :through associations Jul 3, 2025
@joshuay03 joshuay03 moved this to In Progress / Pending Review in Open Source Jul 3, 2025
has_one :location, class_name: "Country"
belongs_to :location, class_name: "Country"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going off of the schema I'm pretty sure this was incorrectly set up, as I don't see any tests that expect this to be invalid.

@joshuay03 joshuay03 force-pushed the through-association-support branch from 62c54e5 to 631ee7e Compare July 3, 2025 14:13
end
RUBY

assert_equal(2, response.size)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without patch:
Screenshot 2025-07-03 at 11 52 27 pm

end
RUBY

assert_equal(2, response.size)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without patch:
Screenshot 2025-07-03 at 11 53 04 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant