find instance variable references with matched scopes #3377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
monkeyWzr
changed the title
vinistock
approved these changes
May 15, 2025
| super() | ||
| @name = name | ||
| @receiver_ancestors = receiver_ancestors |
There was a problem hiding this comment.
Let's call this owner_ancestors since instance variables don't technically have a receiver.
| @@ -321,7 +325,10 @@ def collect_constant_references(name, location) | |||
| def collect_instance_variable_references(name, location, declaration) | |||
| return unless @target.is_a?(InstanceVariableTarget) && name == @target.name | |||
|
|
|||
| @references << Reference.new(name, location, declaration: declaration) | |||
| receiver_type = @stack.join("::") | |||
There was a problem hiding this comment.
This helper method handles the namespaces considering top level references too.
module Foo
class ::Bar; end
end
Suggested change
| receiver_type = @stack.join("::") | |
| receiver_type = Index.actual_nesting(@stack, nil) |
Comment on lines
+369
to
+370
| def find_instance_variable_references(instance_variable_name, receiver_ancestors, source) | ||
| target = ReferenceFinder::InstanceVariableTarget.new(instance_variable_name, receiver_ancestors) |
There was a problem hiding this comment.
Suggested change
| def find_instance_variable_references(instance_variable_name, receiver_ancestors, source) | |
| target = ReferenceFinder::InstanceVariableTarget.new(instance_variable_name, receiver_ancestors) | |
| def find_instance_variable_references(instance_variable_name, owner_ancestors, source) | |
| target = ReferenceFinder::InstanceVariableTarget.new(instance_variable_name, owner_ancestors) |
vinistock
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#2787 (review)
Implementation
Find instance variables references only with matched scopes.
Automated Tests
Added.
Manual Tests
Right click on an instance variable and select
Find All References.