Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rule against memoizing possibly falsely values #195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add rule against memoizing possibly falsely values #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,21 @@ documentation](https://docs.rubocop.org/rubocop/configuration.html#inheriting-co
@enabled = true unless defined?(@enabled)
~~~

* Avoid using `||=` to memoize possibly falsey (`false` or `nil`) values.

~~~ ruby
# bad - will repeat lookup each time if it returns nil
def existing_record
@existing_record ||= expensive_lookup_that_might_return_nil
end

# good
def existing_record
return @existing_record if defined?(@existing_record)
@existing_record = expensive_lookup_that_might_return_nil
end
~~~

* Avoid spaces between a method name and the opening parenthesis.

* Prefer the lambda literal syntax over `lambda`.
Expand Down