Add app-bridge-react and polaris to optimizeDeps #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In development its possible (but an edge case) that navigating from one page without these dependencies to another page with the dependencies would cause a full page refresh, which then redirects to the logicn page. By adding this config, we should avoid that edge case
byrichardpowell
requested review from
lizkenyon
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
In development its possible (but an edge case) that navigating from one page without these dependencies to another page with the dependencies would cause a full page refresh, which then redirects to the logicn page. By adding this config, we should avoid that edge case
WHAT is this pull request doing?
Adds 2 dependencies to optimize dependencies.
Test this PR
Checklist
README.mdfile and other related documentation, if applicableCHANGELOG.md