Simplify dependency installation UI

Shopify · Jun 1, 2020 · 7e2cd5b · 7e2cd5b
1 parent 7bb6711
commit 7e2cd5b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/project_types/script/layers/application/project_dependencies.rb b/lib/project_types/script/layers/application/project_dependencies.rb
@@ -9,9 +9,9 @@ def self.bootstrap(ctx:, language:, extension_point:, script_name:)
 
         def self.install(ctx:, language:, extension_point:, script_name:)
           dep_manager = Infrastructure::DependencyManager.for(ctx, language, extension_point, script_name)
-          return ctx.puts(ctx.message('script.project_deps.deps_are_installed')) if dep_manager.installed?
 
-          unless CLI::UI::Frame.open(ctx.message('script.project_deps.installing_with_npm')) do
+          unless CLI::UI::Frame.open(ctx.message('script.project_deps.checking_with_npm')) do
+            return ctx.puts(ctx.message('script.project_deps.none_required')) if dep_manager.installed?
             begin
               UI::StrictSpinner.spin(ctx.message('script.project_deps.installing')) do |spinner|
                 dep_manager.install

diff --git a/lib/project_types/script/messages/messages.rb b/lib/project_types/script/messages/messages.rb
@@ -126,10 +126,10 @@ module Messages
         },
 
         project_deps: {
-          deps_are_installed: "{{v}} Dependencies installed",
-          installing_with_npm: "Installing dependencies with npm",
+          none_required: "{{v}} None required",
+          checking_with_npm: "Checking dependencies with npm",
           installing: "Dependencies installing",
-          installed: "Dependencies installed",
+          installed: "Missing dependencies installed",
         },
 
         test: {