This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Update Rubocop to 0.85 #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
reviewed
Jun 3, 2020
Gemfile
Outdated
| @@ -8,7 +8,7 @@ group :development, :test do | |||
| gem 'rake' | |||
| gem 'pry-byebug' | |||
| gem 'byebug' | |||
| gem 'rubocop' | |||
| gem 'rubocop', '~> 0.85.0' | |||
There was a problem hiding this comment.
I don't think we should set a specific constraint here.
There was a problem hiding this comment.
If rubocop will fail in other versions, having a constraint makes sense, no?
There was a problem hiding this comment.
We only need to update Gemfile.lock for that.
(some projects do prefer to specify constraints for everything in the Gemfile, but since we're not doing that currently, I think we should following the existing convention).
andyw8
approved these changes
Jun 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Shopify's Ruby style guide introduced a new cop yesterday (Lint/DeprecatedOpenSSLConstant) that is only supported in Rubocop v0.84+ (Shopify/ruby-style-guide#164). If we dont add this then all our future Travis checks would fail.
WHAT is this pull request doing?
Updates the Rubocop development dependency v0.85.0.