Reworked

Shopify · Dec 19, 2024 · 6f90bcc · 6f90bcc
1 parent 625d79e
commit 6f90bcc
Show file tree

Hide file tree

Showing 8 changed files with 1,252 additions and 287 deletions.
diff --git a/.changeset/chilled-bugs-juggle.md b/.changeset/chilled-bugs-juggle.md
@@ -3,4 +3,4 @@
 'theme-check-vscode': minor
 ---
 
-Add the `ValidBlockPresetSettings` check.
+Add the `ValidPresetSettings` check. This check will allow us to validate that the settings defined in sections and blocks are valid. They are valid if they exist in either the block settings or the section settings.
diff --git a/packages/theme-check-common/src/checks/index.ts b/packages/theme-check-common/src/checks/index.ts
@@ -45,7 +45,7 @@ import { ValidSchemaName } from './valid-schema-name';
 import { ValidStaticBlockType } from './valid-static-block-type';
 import { VariableName } from './variable-name';
 import { MissingSchema } from './missing-schema';
-import { ValidBlockPresetSettings } from './valid-block-preset-settings';
+import { ValidPresetSettings } from './valid-preset-settings';
 
 export const allChecks: (LiquidCheckDefinition | JSONCheckDefinition)[] = [
   AppBlockValidTags,
@@ -93,7 +93,7 @@ export const allChecks: (LiquidCheckDefinition | JSONCheckDefinition)[] = [
   ValidStaticBlockType,
   VariableName,
   ValidSchemaName,
-  ValidBlockPresetSettings,
+  ValidPresetSettings,
 ];
 
 /**

diff --git a/packages/theme-check-common/src/checks/valid-block-preset-settings/index.spec.ts b/packages/theme-check-common/src/checks/valid-block-preset-settings/index.spec.ts
diff --git a/packages/theme-check-common/src/checks/valid-block-preset-settings/index.ts b/packages/theme-check-common/src/checks/valid-block-preset-settings/index.ts