Fixed MissingSchema theme check

.changeset/hot-vans-fail.md

@@ -0,0 +1,5 @@
+---
+'@shopify/theme-check-common': minor
+---
+
+This update ensures that the AppBlockMissingSchema theme check will only run on block files on theme app extensions, to avoid errors surfacing when the theme check is incorrectly run on snippets.

packages/theme-check-common/src/checks/missing-schema/index.spec.ts → packages/theme-check-common/src/checks/app-block-missing-schema/index.spec.ts

@@ -1,10 +1,9 @@
 import { describe, expect, it } from 'vitest';
 import { runLiquidCheck } from '../../test';
-import { MissingSchema } from './index';
-import { Config } from '../../types';
+import { AppBlockMissingSchema } from './index';
 
-describe('MissingSchema', () => {
-  it('should report an error when schema tag is missing on a theme app extension', async () => {
+describe('AppBlockMissingSchema', () => {
+  it('should report an error when schema tag is missing on a theme app extension (blocks only)', async () => {
     const sourceCode = `
       <footer class="footer">
         {% for block in section.blocks %}
@@ -23,8 +22,10 @@ describe('MissingSchema', () => {
       </footer>
     `;
 
-    const offenses = await runLiquidCheck(MissingSchema, sourceCode);
+    let offenses = await runLiquidCheck(AppBlockMissingSchema, sourceCode, 'blocks/footer.liquid');
     expect(offenses).to.have.lengthOf(1);
+    offenses = await runLiquidCheck(AppBlockMissingSchema, sourceCode, 'snippets/footer.liquid');
+    expect(offenses).to.have.lengthOf(0);
   });
 
   it('should not report when the schema is present on a theme app extension', async () => {
@@ -81,7 +82,11 @@ describe('MissingSchema', () => {
 }
 {% endschema %}`;
 
-    const offenses = await runLiquidCheck(MissingSchema, sourceCode);
+    const offenses = await runLiquidCheck(
+      AppBlockMissingSchema,
+      sourceCode,
+      'blocks/footer.liquid',
+    );
     expect(offenses).to.have.lengthOf(0);
   });
 });

packages/theme-check-common/src/checks/missing-schema/index.ts → packages/theme-check-common/src/checks/app-block-missing-schema/index.ts

@@ -1,13 +1,13 @@
 import { ConfigTarget, LiquidCheckDefinition, Severity, SourceCodeType } from '../../types';
 
-export const MissingSchema: LiquidCheckDefinition = {
+export const AppBlockMissingSchema: LiquidCheckDefinition = {
   meta: {
-    code: 'MissingSchema',
-    name: 'Missing schema definitions in theme app extensions should be avoided',
+    code: 'AppBlockMissingSchema',
+    name: 'Missing schema definitions in app blocks (specific to theme app extensions) should be avoided',
     docs: {
-      description: 'Report missing schema definitions in theme app extensions',
+      description: 'Report missing schema definitions in theme app extensions app blocks',
       recommended: true,
-      url: 'https://shopify.dev/docs/storefronts/themes/tools/theme-check/checks/missing-schema',
+      url: 'https://shopify.dev/docs/storefronts/themes/tools/theme-check/checks/app-block-missing-schema',
     },
     severity: Severity.ERROR,
     type: SourceCodeType.LiquidHtml,
@@ -17,6 +17,15 @@ export const MissingSchema: LiquidCheckDefinition = {
 
   create(context) {
     let foundSchema = false;
+    const relativePath = context.toRelativePath(context.file.uri);
+
+    /**
+     * Theme app extension blocks are the only types of files that can have a
+     * schema defined in them.
+     */
+    if (!relativePath.startsWith('blocks/')) {
+      return {};
+    }
 
     return {
       async LiquidRawTag(node) {

packages/theme-check-common/src/checks/index.ts

@@ -44,8 +44,7 @@ import { ValidSchema } from './valid-schema';
 import { ValidSchemaName } from './valid-schema-name';
 import { ValidStaticBlockType } from './valid-static-block-type';
 import { VariableName } from './variable-name';
-import { MissingSchema } from './missing-schema';
-import { ValidBlockPresetSettings } from './valid-block-preset-settings';
+import { AppBlockMissingSchema } from './app-block-missing-schema';
 
 export const allChecks: (LiquidCheckDefinition | JSONCheckDefinition)[] = [
   AppBlockValidTags,
@@ -71,7 +70,7 @@ export const allChecks: (LiquidCheckDefinition | JSONCheckDefinition)[] = [
   MatchingTranslations,
   MissingAsset,
   MissingTemplate,
-  MissingSchema,
+  AppBlockMissingSchema,
   PaginationSize,
   ParserBlockingScript,
   SchemaPresetsBlockOrder,
@@ -93,7 +92,6 @@ export const allChecks: (LiquidCheckDefinition | JSONCheckDefinition)[] = [
   ValidStaticBlockType,
   VariableName,
   ValidSchemaName,
-  ValidBlockPresetSettings,
 ];
 
 /**