Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block rename handler (replace old->new everywhere!) #655

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add block rename handler (replace old->new everywhere!) #655

wants to merge 5 commits into from

Conversation

charlespwd
Copy link
Contributor

@charlespwd charlespwd commented Dec 5, 2024 •
edited
Loading

What are you adding in this PR?

WIP

This is currently blocked by #654

  • section schemas
  • block schemas
  • content_for "block", type: "old-name"
  • templates/*.json files
  • sections/*.json files
on-block-rename.mp4

What's next? Any followup issues?

What did you learn?

Before you deploy

  • This PR includes a new checks or changes the configuration of a check
    • I included a minor bump changeset
    • It's in the allChecks array in src/checks/index.ts
    • I ran yarn build and committed the updated configuration files
      • If applicable, I've updated the theme-app-extension.yml config
  • I included a minor bump changeset
  • My feature is backward compatible
  • I included a patch bump changeset

@charlespwd charlespwd linked an issue Dec 5, 2024 that may be closed by this pull request
Renaming a block should update old references #547
Open
@charlespwd
Add AST support of JSONC (for theme check, language features, etc.)
c371b48 
- Rip out `json-to-ast`
- Inline the `json-to-ast` types in `theme-check-common/src/jsonc`
- Make a little `jsonc-parser#Node` -> `json-to-ast#ASTNode` adapter

Fixes #654
@charlespwd
--wip-- [skip ci]
27140cb
@charlespwd
--wip-- [skip ci]
15cf74e
@charlespwd charlespwd force-pushed the feature/block-rename-handling branch from 9b21030 to 15cf74e Compare December 6, 2024 16:37
@albchu albchu self-requested a review December 9, 2024 21:13
@albchu
Copy link
Contributor

albchu commented Dec 9, 2024

Going to try and get the jsonc PR #656 merged as soon as we can here before assessing what kind of assistance we can apply to this PR before CP returns from holiday break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albchu albchu Awaiting requested review from albchu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Renaming a block should update old references
3 participants
@charlespwd @albchu @navdeep5