[vscode extension] Profile annotations and webview #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmath
force-pushed
the
sfr-profiling
branch
3 times, most recently
from
e9b69f7 to
7f842d9
Compare
madmath
force-pushed
the
sfr-profiling
branch
from
7f842d9 to
5ae9d48
Compare
charlespwd
force-pushed
the
sfr-profiling
branch
from
63bbac5 to
6c472bf
Compare
1. Replace `execSync` with a `promisify(exec)` to prevent extension hang 2. Rename files to fit our conventions 3. Remove the `_` prefix from private variables 4. Move the spec file next to the profiler file
charlespwd
force-pushed
the
sfr-profiling
branch
from
084201e to
9985305
Compare
aswamy
reviewed
Jan 14, 2025
| export async function fetchProfileContents(url: string) { | ||
| try { | ||
| console.log('[Liquid Profiler] Attempting to load preview for URL:', url); | ||
| const { stdout: result, stderr } = await exec(`${SHOPIFY_CLI_COMMAND} --url=${url} --json`); |
There was a problem hiding this comment.
You should be able to run runCliCommand instead of exec here after this is merged #708
|
I'm converting this back to draft because there's these things we need to worry about:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Command to call out to
shopify theme profile(Shopify/cli#5109) which willshopify theme profileHere's the error if
shopify theme profilefails to execute (for example, CLI version is not up to date or not authenticated)What's next? Any followup issues?
Very much a v1, I think we can improve a few ways from here
Before you deploy
Public API changes, new features
changeset