Add cash tracking session event targets for POS Compliance #2567
+127
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatbattk
requested review from
ProdigyXable,
NathanJolly,
vctrchu,
js-goupil and
Alex-Palad
This comment has been minimized.
This comment has been minimized.
vctrchu
reviewed
Jan 17, 2025
packages/ui-extensions/src/surfaces/point-of-sale/event/input/CashTrackingSessionInput.ts
Show resolved
Hide resolved
fatbattk
force-pushed
the
add-pos-compliance-extension-targets
branch
from
c2e0fcd to
793e51a
Compare
Alex-Palad
reviewed
Jan 20, 2025
packages/ui-extensions/src/surfaces/point-of-sale/event/input/CashTrackingSessionInput.ts
Outdated
Show resolved
Hide resolved
fatbattk
force-pushed
the
add-pos-compliance-extension-targets
branch
from
793e51a to
bf42c5b
Compare
fatbattk
force-pushed
the
add-pos-compliance-extension-targets
branch
from
bf42c5b to
31b4b2c
Compare
vctrchu
approved these changes
Jan 21, 2025
Alex-Palad
approved these changes
Jan 21, 2025
vctrchu
reviewed
Jan 21, 2025
packages/ui-extensions/docs/surfaces/point-of-sale/reference/types/ExtensionTargetType.ts
Outdated
Show resolved
Hide resolved
fatbattk
force-pushed
the
add-pos-compliance-extension-targets
branch
2 times, most recently
from
4155b9b to
d1e91ea
Compare
js-goupil
requested changes
Jan 21, 2025
packages/ui-extensions/src/surfaces/point-of-sale/event/input/CashTrackingSessionInput.ts
Outdated
Show resolved
Hide resolved
fatbattk
force-pushed
the
add-pos-compliance-extension-targets
branch
from
d1e91ea to
f89d0e1
Compare
vctrchu
reviewed
Jan 22, 2025
packages/ui-extensions/src/surfaces/point-of-sale/event/input/CashTrackingSessionInput.ts
Outdated
Show resolved
Hide resolved
js-goupil
approved these changes
Jan 22, 2025
packages/ui-extensions/src/surfaces/point-of-sale/event/input/CashTrackingSessionInput.ts
Outdated
Show resolved
Hide resolved
packages/ui-extensions/src/surfaces/point-of-sale/event/input/CashTrackingSessionInput.ts
Outdated
Show resolved
Hide resolved
fatbattk
force-pushed
the
add-pos-compliance-extension-targets
branch
from
f89d0e1 to
b50a76a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Part of, https://github.com/Shopify/pos-next-react-native/issues/51030
Solution
pos.cash-tracking-session-start.event.observepos.cash-tracking-session-cancel.event.observepos.cash-tracking-session-complete.event.observe🎩
Checklist