Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rebornix.ruby warning #523

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Remove rebornix.ruby warning #523

merged 1 commit into from
Sep 18, 2023

Conversation

vinistock
Copy link
Member

We've had the Rebornix warning for a long time. I think we should remove it at this point.

@vinistock vinistock added this to the 2023-Q3 milestone Aug 22, 2023
@vinistock vinistock self-assigned this Aug 22, 2023
@vinistock vinistock requested a review from a team as a code owner August 22, 2023 15:00
Copy link
Contributor

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any downside to keeping this?

@vinistock
Copy link
Member Author

We received feedback from some folks that they don't read the dialogue and always just click Clean up, unaware that it'll only modify configurations and not uninstall the extension for them.

I think for the extension pack, we can remove this code and avoid showing this all the time. After the Ruby LSP supports the last remaining bits (autocomplete, and indexing methods) then we will be more strict for Shopify developers and just deny usage of Rebornix internally.

@Morriar
Copy link
Contributor

Morriar commented Aug 23, 2023

they don't read the dialogue and always just click Clean up, unaware that it'll only modify configurations and not uninstall the extension for them

Could we uninstall the extension for them then? Not sure if this is possible from the API but we could call code --uninstall-extension <extension-id>.

@vinistock
Copy link
Member Author

It is possible, but not super straight forward. Rebornix has a dependency on another extension. So we need to

  • Uninstall Rebornix
  • The next time VS Code is reloaded, then we can uninstall the dependency (it's not possible to uninstall both in one go as far as I know)

@vinistock vinistock merged commit 168c17b into main Sep 18, 2023
5 checks passed
@vinistock vinistock deleted the vs/remove_rebornix_warning branch September 18, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants