Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort item gathering when quit UI #69

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

Milly
Copy link
Contributor

@Milly Milly commented Jul 14, 2023

Use events instead of checking flags in a loop, because we can't cancel until the next chunk arrives.

For example, if you run ddu-soure-rg in the root directory... the ripgrep process will continue to run even if you quit the UI.

Use events instead of checking flags in a loop, because we can't cancel
until the next chunk arrives.
@Shougo Shougo merged commit 77bc8d5 into Shougo:main Jul 14, 2023
@Shougo
Copy link
Owner

Shougo commented Jul 14, 2023

Thank you.

@Milly Milly deleted the cancel-gather branch July 14, 2023 11:13
Milly added a commit to Milly/ddu.vim that referenced this pull request Jul 27, 2023
Interrupting by signals works fine.
Related Shougo#69.
@Milly Milly mentioned this pull request Jul 27, 2023
Milly added a commit to Milly/ddu.vim that referenced this pull request Jul 27, 2023
Interrupting by signals works fine.
Related Shougo#69.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants