Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation in Feedback.js #235

Conversation

student-aditipaliwal
Copy link

@student-aditipaliwal student-aditipaliwal commented Jan 21, 2024

Fixes #230

Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for ar-webstore ready!

Name Link
🔨 Latest commit d3aac83
🔍 Latest deploy log https://app.netlify.com/sites/ar-webstore/deploys/65acd2aef3342f0008718190
😎 Deploy Preview https://deploy-preview-235--ar-webstore.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShwetKhatri2001
Copy link
Owner

Good work @student-aditipaliwal !
Can you make these changes to make it valid for `Easy ' level?

  • Name, Email, and the first question What did you like most about AR-Webstore? needs to be mandatory to submit the form. Alert if they are not valid/empty.
  • Similarly add validation to check valid email format and non-empty answer to the first question.
  • Show error messages in light red color and small font size.

I can merge this after that.

@student-aditipaliwal
Copy link
Author

student-aditipaliwal commented Jan 21, 2024 via email

@ShwetKhatri2001
Copy link
Owner

Will you be able to complete this in the next few days @student-aditipaliwal ?

@ShwetKhatri2001
Copy link
Owner

Closing this PR because of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback : Form validation
2 participants