Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automated docker build process #266

Merged
merged 180 commits into from
Nov 23, 2023
Merged

Conversation

jasminabrar
Copy link
Contributor

  • added GitHub action to build docker image using Dockerfile, storing it as a package in the repo
  • docker image rebuilds any time (1) a change to Dockerfile is made via a direct push or merged PR, or (2) a new version of siepic tools or ebeam pdk is released

Notes

  • Currently the EBeam Tests action is referring to the docker image in my (jasminabrar) forked repo. Once this PR is merged, we can trigger the docker build action to run and the docker image will be built and pushed as a package to this main repo. Then we can change the EBeam Tests to refer to this image, and from then on will use images stored in this repo
  • EBeam Tests is currently failing due to a pcell TestStruct_DoubleBus_Ring not being registered in EBeam Beta

Fariha Shaikh and others added 30 commits November 10, 2023 15:37
New GitHub actions workflow to build docker image
changing back to --tag
@lukasc-ubc lukasc-ubc merged commit be6e8fa into SiEPIC:master Nov 23, 2023
1 check passed
@lukasc-ubc
Copy link
Member

TestStruct_DoubleBus_Ring.py has been moved to the folder "broken", so all the cells should load correctly.

@lukasc-ubc
Copy link
Member

Wow, I see the test passed! I looked in the Details and it has checked all the PCells!
Congrats on getting this working @FarihaIS and @jasminabrar!

image

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants