Dev #310
Merged
Dev #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
putting the spiral middle (where it switches from CW to CCW), on one side, to reduce the number of SM to MM converters (two fewer). Thanks Pegah at UBC.
SiN with 50 µm bend radius and bezier parameters. @jingxiang would you be able to optimize the bends for the standard SiN process? 1310, 1550 nm? There are different waveguide widths as well, so wondering what is a good choice. thanks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 73.60% 73.75% +0.15%
==========================================
Files 94 96 +2
Lines 11682 11792 +110
==========================================
+ Hits 8598 8697 +99
- Misses 3084 3095 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.