Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weekly assignment 1 complete #3

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ryanpark04
Copy link

The first three tests (Counter increments correctly, Counter decrements correctly, Counter resets to zero) don't pass in VS Code but they work in my app.

@adrian-szwejk
Copy link
Contributor

Hey Ryan, I read through your commit and it mostly looks good, I can't seem to find the _counter variable you are changing, idk if I'm just blind or if it didn't save when you committed but that might be triggering the test cases. Then for the zero-button you used a text widget for '0' instead of Icons.remove (which is what we used in the test cases and caused it to fail b/c of that) but that isn't that important. Regardless your code structure/logic looks correct and we're still working on perfecting the test cases so I appreciate your feedback and we'll work on it.

jshalabi03 added a commit to jshalabi03/SigMobileAssignments that referenced this pull request Oct 11, 2022
adrian-szwejk added a commit that referenced this pull request Oct 18, 2022
added instructions for #3 weekly assignment
adrian-szwejk added a commit that referenced this pull request Oct 18, 2022
Finished the instructions for #3 weekly assignment
@ApoorvaAditya
Copy link
Contributor

Good job on Assignment 3, Ryan! The code looks good. Even though it doesn't pass all the tests, it has all the required functionality. One thing I would recommend is to look at the CircleAvatar widget as it is common widget that will pop up when you build more complex apps and our objective for adding that widget in this assignment was to introduce some new common widgets that will be pretty useful. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants