Limit lowest possible sub-score for a host #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8maninger
reviewed
Oct 25, 2024
n8maninger
approved these changes
Oct 29, 2024
ChrisSchinnerl
force-pushed
the
chris/clamp-score
branch
from
cc12cee
to
aabc509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1595
The value
0.1was picked mostly because it seemed reasonable that when comparing a perfect host to another one that fails in a single category would be 10x more likely to get picked as a host.Similarly when compared to a host that fails in every category a perfect host would be 10,000,000x more likely to be picked.
So there is still an exponential component to it but the approach in this PR lessens the impact of potential temporary issues or bugs.