Add RHP4 client wrapper #1630
Merged
Add RHP4 client wrapper #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/rhp4
branch
from
643895b
to
57d2675
Compare
peterjan
reviewed
Oct 30, 2024
peterjan
reviewed
Oct 30, 2024
I was holding off on that for the PR that upgrades host scanning to v4 since we aren't using this client yet. Because there we get it implicitly by running the tests against a block height > require height. |
peterjan
approved these changes
Oct 31, 2024
n8maninger
added a commit
that referenced
this pull request
Nov 1, 2024
Merging #1630 which uses the `rhp4` branch of `hostd` broke web, cluster, and benchmark. This is the bare-minimum to get everything aligned on actually merged code again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
rhp4Clientto bothworkerandbus. The client is similar to the existing ones we have.NOTE: The client doesn't implement any RPCs yet except for the settings one as an example. The corresponding PRs will implement those RPCs and make any chances to the signatures if needed.