Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core dependencies #1652

Merged
merged 9 commits into from
Nov 6, 2024
Merged

Update core dependencies #1652

merged 9 commits into from
Nov 6, 2024

Conversation

ChrisSchinnerl
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl commented Nov 4, 2024

Updating the core dependencies on master to make sure we get all the fixes into v1.1.0.

peterjan
peterjan previously approved these changes Nov 4, 2024
Copy link
Member

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n8maninger
Copy link
Member

n8maninger commented Nov 4, 2024

@ChrisSchinnerl removing the prefixes broke the hosts table. RHP2 settings stored in the database have the addr: prefix so can't be deserialized. I had to reset the scans on our databases manually. There may be other locations like that to check.

Copy link
Member

@n8maninger n8maninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes per my comment #1652 (comment)

n8maninger
n8maninger previously approved these changes Nov 5, 2024
peterjan
peterjan previously approved these changes Nov 6, 2024
@ChrisSchinnerl
Copy link
Member Author

Tested this more times than I'd like to admit. 5+ times on testnet and also icarus.
The changes to the contractor were necessary to avoid migration due to the unscanned hosts.

@ChrisSchinnerl ChrisSchinnerl merged commit f0ce445 into master Nov 6, 2024
9 checks passed
@ChrisSchinnerl ChrisSchinnerl deleted the chris/update-core branch November 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants