Skip to content

Commit

Permalink
fix: use a variable for which python version to use in packaging test…
Browse files Browse the repository at this point in the history
…s consistently
  • Loading branch information
miigotu authored Feb 12, 2024
1 parent 053d0e6 commit 17b89aa
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ env:
DOCKER_CONTAINER_NAME: sickchill_test
TARGET_PLATFORMS: "linux/amd64,linux/arm64"
CRYPTOGRAPHY_DONT_BUILD_RUST: 1
PYTHON_TEST_VERSION: "3.11"

defaults:
run:
Expand Down Expand Up @@ -83,10 +84,10 @@ jobs:
experimental: [ false ]
include:
- os: windows-latest
python-version: "3.11"
python-version: ${{ env.PYTHON_TEST_VERSION }}
experimental: false
- os: macos-latest
python-version: "3.11"
python-version: ${{ env.PYTHON_TEST_VERSION }}
experimental: false
fail-fast: true
continue-on-error: ${{ matrix.experimental }}
Expand All @@ -97,7 +98,7 @@ jobs:
with:
fetch-depth: 1
persist-credentials: false
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == '3.10'
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == env.PYTHON_TEST_VERSION
name: Lint shell scripts
uses: ludeeus/action-shellcheck@master
with:
Expand All @@ -107,13 +108,13 @@ jobs:
with:
python-version: ${{ matrix.python-version }}
python-cache-dependency-path: pyproject.toml
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == '3.10'
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == env.PYTHON_TEST_VERSION
name: Set up Node
uses: actions/setup-node@v4
with:
node-version: '20.x'
cache: 'yarn'
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == '3.10'
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == env.PYTHON_TEST_VERSION
name: Install yarn
run: npm install -g yarn
- name: Install python dependency tools
Expand All @@ -126,13 +127,13 @@ jobs:
- name: Install sickchill
run: |
poetry install --no-interaction --with dev --with speedups
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == '3.11'
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == env.PYTHON_TEST_VERSION
name: Run yarn
run: poetry run poe yarn
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == '3.11'
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == env.PYTHON_TEST_VERSION
name: Lint Python
run: poetry run poe lint
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == '3.11'
- if: success() && startsWith(runner.os, 'Linux') && matrix.python-version == env.PYTHON_TEST_VERSION
name: Lint and test Javascript
run: poetry run poe yarn test
- name: Test Python
Expand Down

0 comments on commit 17b89aa

Please sign in to comment.