Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hidden reversal #8606

Merged
merged 3 commits into from
Nov 3, 2023
Merged

hidden reversal #8606

merged 3 commits into from
Nov 3, 2023

Conversation

BKSteve
Copy link
Collaborator

@BKSteve BKSteve commented Oct 28, 2023

Fixes the one hidden that needed to be a selected
The only one found.
Also hooked the Associated file extensions list to be hidden if unselected.

Summary by CodeRabbit

Release Notes

  • Refactor: Updated the Post Processing settings page to improve visibility of the option to move associated files based on user settings.
  • Bug Fix: Adjusted the Providers settings page to correctly enable or disable a checkbox based on the provider's daily capabilities.
  • Bug Fix: Modified the Edit Show page to correctly disable the 'Season Folders' checkbox based on the user's naming settings.

These changes enhance the user interface's intuitiveness by ensuring settings and options are displayed or hidden based on relevant conditions, improving overall user experience.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2023

Walkthrough

The recent changes primarily focus on enhancing the user interface by modifying the visibility and interactivity of certain elements. This is achieved by altering the attributes of HTML elements based on the values of various settings and properties, thereby providing a more dynamic and responsive user experience.

Changes

File Path Summary
.../config_postProcessing.mako The visibility of content_move_associated_files div is now controlled by settings.MOVE_ASSOCIATED_FILES. The associated file extensions field has been removed.
.../config_providers.mako The disabled attribute of a checkbox is now determined by curTorrentProvider.can_daily, allowing it to be disabled based on this value.
.../editShow.mako The checkbox with id "season_folders" is disabled if settings.NAMING_FORCE_FOLDERS is false.

🐇

"In the land of code, where the shadows lie,

Changes are made, under the AI's eye.

With each attribute tweak, and each div's dance,

We enhance the user's glance.

So here's to the code, ever so bright,

Guiding us through the digital night." 🌙


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between d64f1a2 and 345c46d.
Files selected for processing (1)
  • sickchill/gui/slick/views/config_postProcessing.mako (1 hunks)
Files skipped from review due to trivial changes (1)
  • sickchill/gui/slick/views/config_postProcessing.mako

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 345c46d and 28806d1.
Files selected for processing (2)
  • sickchill/gui/slick/views/config_providers.mako (1 hunks)
  • sickchill/gui/slick/views/editShow.mako (1 hunks)
Files skipped from review due to trivial changes (2)
  • sickchill/gui/slick/views/config_providers.mako
  • sickchill/gui/slick/views/editShow.mako

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 28806d1 and 4db2ab7.
Files selected for processing (1)
  • sickchill/gui/slick/views/config_providers.mako (4 hunks)
Files skipped from review due to trivial changes (1)
  • sickchill/gui/slick/views/config_providers.mako

@miigotu miigotu merged commit e2af6cc into develop Nov 3, 2023
11 checks passed
@miigotu miigotu deleted the hidden_select branch November 3, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants