Bk steve patch 1 #8610

BKSteve · 2023-11-03T17:00:01Z

sssss

Summary by CodeRabbit

New Features
- Added new GitHub Actions workflows for testing, Docker, dependency upgrades, and release management.
- Added search functionality to the app.
Bug Fixes
- Fixed issues with dismissing the discord banner and errors related to bdecode and torrentleech.
Documentation
- Updated URLs in the README file.
Refactor
- Renamed variables and updated comments in configuration files.
Style
- Updated CSS styles for various elements.
Chores
- Updated versions of various dependencies in package.json and pyproject.toml.
- Modified .editorconfig and .gitignore files.
- Updated GitHub Actions workflows with new versions of actions and added new steps.

coderabbitai · 2023-11-03T17:00:44Z

Walkthrough

The changes in this update focus on improving the configuration, dependencies, workflows, and codebase of the SickChill project. Various configuration files have been updated to adjust indentation rules and specify package versions. Workflows have been modified to change schedules, add new steps, and update actions. Additionally, there are updates to CSS styles, the SickChill class, and documentation files. These changes aim to enhance functionality, maintainability, and user experience.

Changes

File(s)	Summary
`.editorconfig`	Changed indent size for JavaScript files and YAML files. Added configuration for `package.json`, `bower.json`, and `webpack.config.js` files.
`.github/FUNDING.yml`	Updated funding information for SickChill.
`.github/dependabot.yml`	Updated schedule interval, pull request settings, and assignees for package ecosystems.
`.github/workflows/check_release.yml`	Added a new workflow for testing release strings.
`.github/workflows/codeql.yml`	Added concurrency settings and updated actions.
`.github/workflows/docker.yml`	Added a workflow file for Docker projects.
`.github/workflows/pythonpackage.yml`	Updated versions of various actions.
`.github/workflows/release.yml`	Updated actions and steps for releasing SickChill.
`.github/workflows/release_info.yml`	Added a new workflow for getting the next version number.
`.github/workflows/upgrade_dependencies.yml`	Updated workflow for upgrading dependencies.
`.gitignore`	Removed lines related to specific files.
`.pre-commit-config.yaml`	Commented out the "end-of-file-fixer" plugin.
`CHANGES.md`	Various updates and fixes to the SickChill codebase.
`Dockerfile`	Modified the RUN command and added comments.
`Gruntfile.js`	Various changes to the Gruntfile.js file.
`README.md`	Updated URLs in the documentation.
`SickChill.py`	Added a new method and made modifications to existing methods.
`bower.json`	Updated the version of the "pnotify" package.
`contrib/runscripts/init.debian`	Renamed variables and updated comments.
`contrib/runscripts/init.fedora`	Renamed variables and updated default values.
`contrib/runscripts/init.systemd`	Updated an example configuration file.
`contrib/runscripts/init.ubuntu`	Updated variables, file paths, and options.
`contrib/runscripts/init.upstart`	Updated variable names in the script.
`debian/changelog`	Version updates, bug fixes, and dependency changes.
`debian/sickchill.service`	Added the `--no-update` flag to the service command.
`package.json`	Updated versions of dependencies and added new ones.
`pyproject.toml`	Updated URLs, dependencies, and configuration settings.
`qodana.yaml`	Configuration file for Qodana analysis.
`sickchill/gui/slick/css/browser.css`	CSS style changes for the file browser dialog.
`sickchill/gui/slick/css/dark.css`	Various CSS style changes.
`sickchill/gui/slick/css/print.css`	CSS style change for printing.
`sickchill/gui/slick/views/config_providers.mako`	Removed extra characters from a label element.

🐇 "In the heart of fall, with leaves aflutter, 🍂
CodeRabbit hops, no time to utter. 🕰️
With each line of code, crisp as the air, 🌬️
We weave magic in the software lair. 💻
Celebrate the changes, big and small, 🎉
In the world of code, we stand tall!" 🌍

Tips

Chat with CodeRabbit Bot (`@coderabbitai`)

If you reply to a review comment from CodeRabbit, the bot will automatically respond.
To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
Note: Review comments are made on code diffs or files, not on the PR overview.
Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai help to get help.
@coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
The JSON schema for the configuration file is available here.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Gruntfile.js

-            'exec:git_push:origin:master develop' // Push master and develop
-        ]);
-    });
+    ])


Gruntfile.js


                    if (isRelease) {
+                        grunt.task.requires('_get_next_version')


Gruntfile.js

+
+                    let changes = stdout.match(/CHANGES.md/gm);
+                    if (changes) {
+                        commitMsg.push('Update Changelog')


Gruntfile.js

+            contents += '\n';
+            const commits = grunt.config('commits');
+
+            contents = processArray(commits, contents)


Gruntfile.js

        });

        if (contents) {
-            grunt.file.write(file, contents);
+            contents.re


Gruntfile.js

        });

        if (contents) {
-            grunt.file.write(file, contents);
+            contents.re


coderabbitai

Review Status

Actionable comments generated: 9

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between fa39f38 and 54454d4.

Files ignored due to filter (261)

contrib/images/icon.png
contrib/images/vector.svg
sickchill/gui/slick/css/fonts/BoldItalic/OpenSans-BoldItalic.svg
sickchill/gui/slick/css/fonts/ExtraBoldItalic/OpenSans-ExtraBoldItalic.svg
sickchill/gui/slick/css/fonts/Italic/OpenSans-Italic.svg
sickchill/gui/slick/css/fonts/Light/OpenSans-Light.svg
sickchill/gui/slick/css/fonts/LightItalic/OpenSans-LightItalic.svg
sickchill/gui/slick/css/fonts/Regular/OpenSans-Regular.svg
sickchill/gui/slick/css/fonts/SemiboldItalic/OpenSans-SemiboldItalic.svg
sickchill/gui/slick/fonts/fontawesome-webfont.svg
sickchill/gui/slick/fonts/forkawesome-webfont.svg
sickchill/gui/slick/fonts/glyphicons-halflings-regular.svg
sickchill/gui/slick/images/16px_sprite_colored_help-info.png
sickchill/gui/slick/images/16px_sprite_colored_show.png
sickchill/gui/slick/images/Matrix_Web.png
sickchill/gui/slick/images/banner.png
sickchill/gui/slick/images/ico/android-chrome-144x144.png
sickchill/gui/slick/images/ico/android-chrome-192x192.png
sickchill/gui/slick/images/ico/android-chrome-256x256.png
sickchill/gui/slick/images/ico/android-chrome-36x36.png
sickchill/gui/slick/images/ico/android-chrome-384x384.png
sickchill/gui/slick/images/ico/android-chrome-48x48.png
sickchill/gui/slick/images/ico/android-chrome-512x512.png
sickchill/gui/slick/images/ico/android-chrome-72x72.png
sickchill/gui/slick/images/ico/android-chrome-96x96.png
sickchill/gui/slick/images/ico/apple-touch-icon-114x114.png
sickchill/gui/slick/images/ico/apple-touch-icon-120x120.png
sickchill/gui/slick/images/ico/apple-touch-icon-144x144.png
sickchill/gui/slick/images/ico/apple-touch-icon-152x152.png
sickchill/gui/slick/images/ico/apple-touch-icon-180x180.png
sickchill/gui/slick/images/ico/apple-touch-icon-57x57.png
sickchill/gui/slick/images/ico/apple-touch-icon-60x60.png
sickchill/gui/slick/images/ico/apple-touch-icon-72x72.png
sickchill/gui/slick/images/ico/apple-touch-icon-76x76.png
sickchill/gui/slick/images/ico/apple-touch-icon.png
sickchill/gui/slick/images/ico/favicon-32x32.png
sickchill/gui/slick/images/ico/mstile-144x144.png
sickchill/gui/slick/images/ico/mstile-150x150.png
sickchill/gui/slick/images/ico/mstile-310x150.png
sickchill/gui/slick/images/ico/mstile-310x310.png
sickchill/gui/slick/images/ico/mstile-70x70.png
sickchill/gui/slick/images/mattermost.png
sickchill/gui/slick/images/network/13th-street.png
sickchill/gui/slick/images/network/abc-(ph).png
sickchill/gui/slick/images/network/abc-(us).png
sickchill/gui/slick/images/network/abc-news-24.png
sickchill/gui/slick/images/network/abc-news.png
sickchill/gui/slick/images/network/abc-tv.png
sickchill/gui/slick/images/network/abema tv.png
sickchill/gui/slick/images/network/amazon freevee.png
sickchill/gui/slick/images/network/amazon prime video.png
sickchill/gui/slick/images/network/amazon-prime-instant-video.png
sickchill/gui/slick/images/network/amazon-prime.png
sickchill/gui/slick/images/network/amc+.png
sickchill/gui/slick/images/network/american-heroes-channel.png
sickchill/gui/slick/images/network/animal-planet.png
sickchill/gui/slick/images/network/anime-network.png
sickchill/gui/slick/images/network/anixe-hd.png
sickchill/gui/slick/images/network/anixe-sd.png
sickchill/gui/slick/images/network/antena-3.png
sickchill/gui/slick/images/network/apple tv+.png
sickchill/gui/slick/images/network/arte-hd.png
sickchill/gui/slick/images/network/axs-tv.png
sickchill/gui/slick/images/network/bandai-channel.png
sickchill/gui/slick/images/network/bandai-visual.png
sickchill/gui/slick/images/network/bbc iplayer.png
sickchill/gui/slick/images/network/bbc-america.png
sickchill/gui/slick/images/network/bbc-canada.png
sickchill/gui/slick/images/network/bbc-four.png
sickchill/gui/slick/images/network/bbc-iplayer.png
sickchill/gui/slick/images/network/bbc-one.png
sickchill/gui/slick/images/network/bbc-prime.png
sickchill/gui/slick/images/network/bbc-scotland.png
sickchill/gui/slick/images/network/bbc-three.png
sickchill/gui/slick/images/network/bbc-two.png
sickchill/gui/slick/images/network/bet+.png
sickchill/gui/slick/images/network/bilibili.png
sickchill/gui/slick/images/network/biography-channel.png
sickchill/gui/slick/images/network/bnn-vara.png
sickchill/gui/slick/images/network/boomerang.png
sickchill/gui/slick/images/network/bravo-(ca).png
sickchill/gui/slick/images/network/bravo-(uk).png
sickchill/gui/slick/images/network/bravo-(us).png
sickchill/gui/slick/images/network/canal-d.png
sickchill/gui/slick/images/network/canal-off.png
sickchill/gui/slick/images/network/caracol-tv.png
sickchill/gui/slick/images/network/cartoon-network-australia.png
sickchill/gui/slick/images/network/cartoon-network.png
sickchill/gui/slick/images/network/cbc-(ca).png
sickchill/gui/slick/images/network/cbc-(jp).png
sickchill/gui/slick/images/network/cbs all access.png
sickchill/gui/slick/images/network/cbs-all-access.png
sickchill/gui/slick/images/network/channel 101.png
sickchill/gui/slick/images/network/channel-4.png
sickchill/gui/slick/images/network/channel-5.png
sickchill/gui/slick/images/network/channel-ten.png
sickchill/gui/slick/images/network/chiba-tv.png
sickchill/gui/slick/images/network/cooking-channel.png
sickchill/gui/slick/images/network/cottage-life.png
sickchill/gui/slick/images/network/crime-&-investigation-network.png
sickchill/gui/slick/images/network/crime-and-investigation-network.png
sickchill/gui/slick/images/network/ctv drama (bravo).png
sickchill/gui/slick/images/network/cw-seed.png
sickchill/gui/slick/images/network/dailymotion.png
sickchill/gui/slick/images/network/das-vierte.png
sickchill/gui/slick/images/network/dc universe.png
sickchill/gui/slick/images/network/dc-universe.png
sickchill/gui/slick/images/network/deluxe-music.png
sickchill/gui/slick/images/network/destination-america.png
sickchill/gui/slick/images/network/discovery-family.png
sickchill/gui/slick/images/network/discovery-kids.png
sickchill/gui/slick/images/network/discovery-real-time.png
sickchill/gui/slick/images/network/discovery-science.png
sickchill/gui/slick/images/network/disney+.png
sickchill/gui/slick/images/network/disney-channel-(germany).png
sickchill/gui/slick/images/network/disney-channel-(us).png
sickchill/gui/slick/images/network/disney-channel.png
sickchill/gui/slick/images/network/disney-cinemagic.png
sickchill/gui/slick/images/network/disney-xd.png
sickchill/gui/slick/images/network/dmax-(de).png
sickchill/gui/slick/images/network/dropout.png
sickchill/gui/slick/images/network/dumont-television-network.png
sickchill/gui/slick/images/network/e!-(ca).png
sickchill/gui/slick/images/network/einsfestival-hd.png
sickchill/gui/slick/images/network/el-rey-network.png
sickchill/gui/slick/images/network/elisa viihde.png
sickchill/gui/slick/images/network/espn-2.png
sickchill/gui/slick/images/network/eurosport-1.png
sickchill/gui/slick/images/network/eurosport-2.png
sickchill/gui/slick/images/network/eurosport-hd.png
sickchill/gui/slick/images/network/facebook watch.png
sickchill/gui/slick/images/network/food-network-canada.png
sickchill/gui/slick/images/network/food-network.png
sickchill/gui/slick/images/network/fox kids.png
sickchill/gui/slick/images/network/fox-(fi).png
sickchill/gui/slick/images/network/fox-(it).png
sickchill/gui/slick/images/network/fox-(uk).png
sickchill/gui/slick/images/network/fox-(us).png
sickchill/gui/slick/images/network/fox-business.png
sickchill/gui/slick/images/network/fox-sports.png
sickchill/gui/slick/images/network/fox-television-classics.png
sickchill/gui/slick/images/network/france-2.png
sickchill/gui/slick/images/network/france-3.png
sickchill/gui/slick/images/network/fuji-tv.png
sickchill/gui/slick/images/network/funimation-channel.png
sickchill/gui/slick/images/network/funny or die.png
sickchill/gui/slick/images/network/fx-(us).png
sickchill/gui/slick/images/network/g4-canada.png
sickchill/gui/slick/images/network/game-show-network.png
sickchill/gui/slick/images/network/global-tv.png
sickchill/gui/slick/images/network/hbo max.png
sickchill/gui/slick/images/network/history-(ca).png
sickchill/gui/slick/images/network/history-television.png
sickchill/gui/slick/images/network/hulu-presents.png
sickchill/gui/slick/images/network/italia-1.png
sickchill/gui/slick/images/network/itv encore.png
sickchill/gui/slick/images/network/itv-granada.png
sickchill/gui/slick/images/network/itvx.png
sickchill/gui/slick/images/network/kabel-eins-classics.png
sickchill/gui/slick/images/network/kabel-eins-hd.png
sickchill/gui/slick/images/network/kabel-eins.png
sickchill/gui/slick/images/network/kan 11.png
sickchill/gui/slick/images/network/kanal-5-(dk).png
sickchill/gui/slick/images/network/kika-hd.png
sickchill/gui/slick/images/network/kro-ncrv.png
sickchill/gui/slick/images/network/lifetime-uk.png
sickchill/gui/slick/images/network/manhattan-neighborhood-network.png
sickchill/gui/slick/images/network/mbc-1.png
sickchill/gui/slick/images/network/military-channel.png
sickchill/gui/slick/images/network/motorvision-tv.png
sickchill/gui/slick/images/network/mtv-brazil.png
sickchill/gui/slick/images/network/nat-geo-wild.png
sickchill/gui/slick/images/network/nbcu-tv.png
sickchill/gui/slick/images/network/nederland-1.png
sickchill/gui/slick/images/network/nederland-2.png
sickchill/gui/slick/images/network/nederland-3.png
sickchill/gui/slick/images/network/neo-kika.png
sickchill/gui/slick/images/network/net-5.png
sickchill/gui/slick/images/network/network-ten.png
sickchill/gui/slick/images/network/nick-at-nite.png
sickchill/gui/slick/images/network/nick-comedy.png
sickchill/gui/slick/images/network/nicktoons-network.png
sickchill/gui/slick/images/network/nine-network.png
sickchill/gui/slick/images/network/npo-1.png
sickchill/gui/slick/images/network/npo-2.png
sickchill/gui/slick/images/network/omroep-max.png
sickchill/gui/slick/images/network/orf-1.png
sickchill/gui/slick/images/network/orf-2.png
sickchill/gui/slick/images/network/orf-eins.png
sickchill/gui/slick/images/network/orf-iii.png
sickchill/gui/slick/images/network/orf1-hd.png
sickchill/gui/slick/images/network/paramount network.png
sickchill/gui/slick/images/network/phoenix-hd.png
sickchill/gui/slick/images/network/prime-(be).png
sickchill/gui/slick/images/network/prime-(nz).png
sickchill/gui/slick/images/network/prosieben-fun.png
sickchill/gui/slick/images/network/puhutv.png
sickchill/gui/slick/images/network/rai-1.png
sickchill/gui/slick/images/network/rai-2.png
sickchill/gui/slick/images/network/rai-3.png
sickchill/gui/slick/images/network/rai-gulp.png
sickchill/gui/slick/images/network/rede-bandeirantes.png
sickchill/gui/slick/images/network/rede-globo.png
sickchill/gui/slick/images/network/rete-4.png
sickchill/gui/slick/images/network/rte two.png
sickchill/gui/slick/images/network/rte-one.png
sickchill/gui/slick/images/network/rtejr.png
sickchill/gui/slick/images/network/rtl tvi.png
sickchill/gui/slick/images/network/rtl-4.png
sickchill/gui/slick/images/network/rtl-5.png
sickchill/gui/slick/images/network/rtl-7.png
sickchill/gui/slick/images/network/rtl-8.png
sickchill/gui/slick/images/network/rtl-crime-hd.png
sickchill/gui/slick/images/network/rtl-hd.png
sickchill/gui/slick/images/network/rtl-ii.png
sickchill/gui/slick/images/network/rtl-passion-hd.png
sickchill/gui/slick/images/network/rtl-television.png
sickchill/gui/slick/images/network/rtl-tvi.png
sickchill/gui/slick/images/network/rtl2-hd.png
sickchill/gui/slick/images/network/rtp-internacional.png
sickchill/gui/slick/images/network/rtp-madeira.png
sickchill/gui/slick/images/network/rtp-n.png
sickchill/gui/slick/images/network/sat.1-emotions.png
sickchill/gui/slick/images/network/sat.1-gold.png
sickchill/gui/slick/images/network/sat.1-hd.png
sickchill/gui/slick/images/network/sbs-6.png
sickchill/gui/slick/images/network/science-channel.png
sickchill/gui/slick/images/network/set-tv.png
sickchill/gui/slick/images/network/seven-network.png
sickchill/gui/slick/images/network/showcase-(au).png
sickchill/gui/slick/images/network/showcase-(ca).png
sickchill/gui/slick/images/network/sic-mulher.png
sickchill/gui/slick/images/network/sic-radical.png
sickchill/gui/slick/images/network/sic-sempre-gold.png
sickchill/gui/slick/images/network/sky deutschland.png
sickchill/gui/slick/images/network/sky-1.png
sickchill/gui/slick/images/network/sky-action.png
sickchill/gui/slick/images/network/sky-atlantic-(uk).png
sickchill/gui/slick/images/network/sky-atlantic-hd.png
sickchill/gui/slick/images/network/sky-bundesliga.png
sickchill/gui/slick/images/network/sky-cinema-(it).png
sickchill/gui/slick/images/network/sky-cinema-(uk).png
sickchill/gui/slick/images/network/sky-cinema.png
sickchill/gui/slick/images/network/sky-crime.png
sickchill/gui/slick/images/network/sky-krimi.png
sickchill/gui/slick/images/network/sky-sport-austria.png
sickchill/gui/slick/images/network/sky-sport-news-hd.png
sickchill/gui/slick/images/network/sky-sport1.png
sickchill/gui/slick/images/network/sky-sport2.png
sickchill/gui/slick/images/network/speed-channel.png
sickchill/gui/slick/images/network/spike-tv.png
sickchill/gui/slick/images/network/sport1-hd.png
sickchill/gui/slick/images/network/sportsman-channel.png
sickchill/gui/slick/images/network/srf-zwei.png
sickchill/gui/slick/images/network/star-plus.png
sickchill/gui/slick/images/network/star-tv.png
sickchill/gui/slick/images/network/style-network.png
sickchill/gui/slick/images/network/super-channel.png
sickchill/gui/slick/images/network/super-rtl-hd.png
sickchill/gui/slick/images/network/super-rtl.png
sickchill/gui/slick/images/network/tbs (jp).png

Files selected for processing (32)

.editorconfig (1 hunks)
.github/FUNDING.yml (1 hunks)
.github/dependabot.yml (1 hunks)
.github/workflows/check_release.yml (1 hunks)
.github/workflows/codeql.yml (3 hunks)
.github/workflows/docker.yml (1 hunks)
.github/workflows/pythonpackage.yml (1 hunks)
.github/workflows/release.yml (1 hunks)
.github/workflows/release_info.yml (1 hunks)
.github/workflows/upgrade_dependencies.yml (3 hunks)
.gitignore (1 hunks)
.pre-commit-config.yaml (1 hunks)
CHANGES.md (1 hunks)
Dockerfile (2 hunks)
Gruntfile.js (13 hunks)
README.md (1 hunks)
SickChill.py (9 hunks)
bower.json (1 hunks)
contrib/runscripts/init.debian (2 hunks)
contrib/runscripts/init.fedora (1 hunks)
contrib/runscripts/init.systemd (1 hunks)
contrib/runscripts/init.ubuntu (1 hunks)
contrib/runscripts/init.upstart (2 hunks)
debian/changelog (1 hunks)
debian/sickchill.service (1 hunks)
package.json (3 hunks)
pyproject.toml (8 hunks)
qodana.yaml (1 hunks)
sickchill/gui/slick/css/browser.css (3 hunks)
sickchill/gui/slick/css/dark.css (26 hunks)
sickchill/gui/slick/css/print.css (1 hunks)
sickchill/gui/slick/css/style.css (102 hunks)

Files not summarized due to errors (1)

sickchill/gui/slick/css/style.css: Error: Message exceeds token limit

Files skipped from review due to trivial changes (18)

.editorconfig
.github/FUNDING.yml
.github/workflows/docker.yml
.gitignore
.pre-commit-config.yaml
Dockerfile
README.md
bower.json
contrib/runscripts/init.debian
contrib/runscripts/init.fedora
contrib/runscripts/init.systemd
contrib/runscripts/init.ubuntu
debian/sickchill.service
package.json
qodana.yaml
sickchill/gui/slick/css/browser.css
sickchill/gui/slick/css/dark.css
sickchill/gui/slick/css/print.css

Additional comments: 58

contrib/runscripts/init.upstart (2)

6-14: The comments have been updated to reflect the new variable names. Ensure that all references to these variables in the codebase have been updated as well.

34-38: The script now uses the new variable names. This change is consistent with the updated comments.

.github/dependabot.yml (1)

1-42: The changes to the dependabot.yml file look good. The updates to the schedule, open pull requests limit, pull request branch name separator, and assignees are all valid configurations. Just ensure that the assignee "miigotu" is available and has the necessary permissions to handle these pull requests.

CHANGES.md (1)

1-326: The changes in this markdown file are well-documented and provide a clear history of the project's updates, bug fixes, and improvements. The use of links to specific issues and pull requests is a good practice, providing context and further details for each change. The versioning is clear and consistent, which is crucial for tracking and understanding the evolution of the project.

.github/workflows/codeql.yml (3)

8-13: The concurrency group and cancellation of in-progress jobs have been added. This will prevent multiple runs of the same workflow for the same PR or commit, which can save resources.

31-31: The actions/checkout action has been updated to version 4. Ensure that this version is compatible with the rest of the workflow.

47-57: The gitguardian job is commented out. If it's not needed, consider removing it to keep the code clean. If it's planned to be used in the future, ensure that the GITGUARDIAN_API_KEY secret is set in the repository settings.

.github/workflows/check_release.yml (2)

1-45: This new workflow file looks well-structured and follows the standard conventions for GitHub Actions workflows. It's good to see that the workflow is designed to be manually triggered and accepts an input parameter, which provides flexibility for testing different strings. The use of concurrency to cancel any in-progress runs when a new one is started is a good practice to prevent unnecessary resource usage. The steps in the job are clear and straightforward, and the use of Poetry for managing Python dependencies is a good choice for reproducibility.

45-45: Ensure that the sickchill command with the --test-name option is correctly implemented and handles the input string as expected.
.github/workflows/release.yml (1)
18-41: The changes to the workflow look good. The new versions of the actions are being used and the setup of Poetry has been updated. The use of environment variables for authentication in the "Publish" step is a good practice for security. However, the "Bump version" step seems incomplete. It mentions setting the release version to today's date and using debchange with gbd-change with a new version, but no commands are provided to do so. Please verify this.
-        run: |
-          poetry install
-          # Set release version to todays date
-          # debchange with gbd-change with new version
+        run: |
+          poetry install
+          # Set release version to todays date
+          # Add commands to set the version here
+          # debchange with gbd-change with new version
+          # Add commands to use debchange and gbd-change here
.github/workflows/release_info.yml (1)
1-62: The workflow file seems to be well-structured and follows the standard conventions for GitHub Actions workflows. However, there are a few points to consider:

Line 12: The default value for release_branch is set to ${{ github.branch }}. However, github.branch is not a standard context in GitHub Actions. You might want to use ${{ github.ref }} or ${{ github.head_ref }} instead, depending on your use case.

Line 26: The patch_separator input is defined as a boolean, but the description suggests it should be a string. Please verify this.

Line 56: Ensure that the miigotu/actions-calver@workflows action exists and is reliable. If it's a third-party action, consider pinning it to a specific version or commit hash for security and stability.
-        default: ${{ github.branch }}
+        default: ${{ github.ref }}

-        type: boolean
+        type: string

-        uses: miigotu/actions-calver@workflows
+        uses: miigotu/actions-calver@v1
.github/workflows/upgrade_dependencies.yml (2)

1-7: The name of the workflow and the cron schedule have been updated to use double quotes instead of single quotes. This is a minor change and doesn't affect the functionality of the workflow.

11-48: The job "depends" has been updated with a matrix strategy for the OS, set to "ubuntu-latest". The "checkout" action has been updated to version 4, and the "setup-poetry-env" action has been updated to version 1.1.0 with a new "python-version" input. The "setup-node" action has been updated to version 4 with the "node-version" input changed to "20.x". The "git-auto-commit-action" action has been updated to version 5 with changes to the "commit_options", "push_options", and "add_options" inputs. Ensure that these changes are compatible with the rest of the workflow and that the new versions of the actions are stable and have the necessary features.

SickChill.py (5)

13-14: The Path and List imports are used later in the code for handling file paths and type hinting respectively. Ensure that these modules are installed in your environment.

48:
The SCWebServer class is imported from sickchill.views.server_settings. Ensure that this class exists in the specified module.

105-127: The start method has been updated to handle new command line arguments and options. Ensure that these changes are reflected in the documentation and that all calls to this method have been updated accordingly.

135-144: The creation of the data directory has been modified to use Path.mkdir instead of os.makedirs. This is a more modern and recommended way of handling file paths in Python. However, ensure that the parents=True and exist_ok=True arguments are appropriate for your use case.

189:
A debug option has been added to the web_options dictionary. Ensure that this option is handled correctly in the SCWebServer class.

202-203: The SRWebServer instance has been renamed to SCWebServer. Ensure that this change is reflected throughout the codebase.

358-360: A new static method test_name has been added to test name parsing. Ensure that this method is used correctly throughout the codebase.
debian/changelog (1)
1-10: The changelog is well maintained and provides a clear summary of the changes made in the new version. However, the status of the release is marked as "UNRELEASED". If the version has been released, this should be updated to reflect the correct status.
- sickchill (2023.6.27) UNRELEASED; urgency=medium
+ sickchill (2023.6.27) stable; urgency=medium
pyproject.toml (7)

26-31: The Python version classifiers have been updated to reflect that the project now supports Python 3.8, 3.9, and 3.10. Ensure that the project is compatible with these versions.

41-46: The URLs for "Changelog", "Bug Tracker", "News", "Discord", "IRC", and "Donate" have been updated. Verify that these URLs are correct and accessible.

70-72: The version ranges for "poethepoet" and "pre-commit" dependencies have been updated. Ensure that these changes do not introduce any breaking changes or compatibility issues.

176-179: The configuration for the "black" tool has been updated. Ensure that these changes align with the project's coding style guidelines.

254-275: The version ranges for the "tornado", "validators", "Send2Trash", and other dependencies have been updated. Ensure that these changes do not introduce any breaking changes or compatibility issues.

279-284: The version ranges for the "Send2Trash" and other dependencies have been updated. Ensure that these changes do not introduce any breaking changes or compatibility issues.

290-299: The version ranges for the "stevedore", "cachecontrol", and other dependencies have been updated. The "cachecontrol" dependency has been added. Ensure that these changes do not introduce any breaking changes or compatibility issues.

.github/workflows/pythonpackage.yml (11)

38-78: The Docker meta step has been updated to use version 5 of the docker/metadata-action. Ensure that the new version is compatible with the rest of your workflow and that all necessary changes have been made to accommodate this update.

82-90: The Python versions used for testing have been updated to include 3.10 and 3.11. Ensure that your code is compatible with these versions.

96-98: The Checkout step has been updated to use version 4 of the actions/checkout action. Ensure that the new version is compatible with the rest of your workflow and that all necessary changes have been made to accommodate this update.

106-110: The Setup Poetry step has been updated to use version 1.1.0 of the 5yutan5/setup-poetry-env action. Ensure that the new version is compatible with the rest of your workflow and that all necessary changes have been made to accommodate this update.

112-116: The Set up Node step has been updated to use version 4 of the actions/setup-node action and Node version 20.x. Ensure that the new versions are compatible with the rest of your workflow and that all necessary changes have been made to accommodate these updates.

154-158: The Set up QEMU and Set up Docker Buildx steps have been updated to use version 3 of the docker/setup-qemu-action and docker/setup-buildx-action actions respectively. Ensure that the new versions are compatible with the rest of your workflow and that all necessary changes have been made to accommodate these updates.

160-172: The Test Docker Build step has been updated to use version 5 of the docker/build-push-action action. Ensure that the new version is compatible with the rest of your workflow and that all necessary changes have been made to accommodate this update.

201-211: The Login to DockerHub and Login to GitHub Container Registry steps have been updated to use version 3 of the docker/login-action action. Ensure that the new version is compatible with the rest of your workflow and that all necessary changes have been made to accommodate this update.

214-226: The Build and Push step has been updated to use version 5 of the docker/build-push-action action. Ensure that the new version is compatible with the rest of your workflow and that all necessary changes have been made to accommodate this update.

229-240: The Snag wheels step has been updated to use version 5 of the docker/build-push-action action. Ensure that the new version is compatible with the rest of your workflow and that all necessary changes have been made to accommodate this update.

261-265: A new step named "Packaging tests completed" has been added to the workflow. This step simply prints "Success!" to the console when all previous steps have completed successfully.

Gruntfile.js (12)

10-23: The publish task has been updated to include additional steps. Ensure that these steps are correctly sequenced and that they perform the intended operations. Also, verify that the exec:check_return_branch task correctly saves the current branch for later use.

30-50: The publish task has been further modified to include additional steps. Ensure that these steps are correctly sequenced and that they perform the intended operations. Also, verify that the exec:git:merge:develop --strategy-option theirs command correctly merges the develop branch into the master branch.

256-268: The bump_version task has been added. This task updates the version in pyproject.toml. Ensure that the version bumping logic is correct and that the new version is correctly written to pyproject.toml.

273-279: The delete_today_tags task has been added. This task deletes all git tags from the current day. Ensure that this task correctly identifies and deletes the intended tags.

292-300: The commit_changed_files task has been updated. This task now commits updates to translations and grunt. Ensure that the changes are correctly identified and committed.

304-330: The commit_changed_files task has been further updated. This task now commits updates to the changelog, translations, and grunt. Ensure that the changes are correctly identified and committed.

345-352: The commit_combined task has been added. This task commits a combination of changes. Ensure that the changes are correctly identified and committed.

383-393: > Note: This review was outside of the patch, so it was mapped to the patch with the greatest overlap. Original lines [367-393]

The git_tag_next_version task has been added. This task creates a new release tag. Ensure that the new tag is correctly created and that the tag message is correctly formatted.

412-425: The git_list_tags task has been updated. This task now includes a different regex pattern. Ensure that this pattern correctly matches the intended tags.

482-494: The _get_next_version task has been updated. This task now includes logic to handle cases where the next version is the same as the last version. Ensure that this logic correctly handles these cases and that the new version is correctly generated.

499-553: The _genchanges task has been added. This task generates a changelog. Ensure that the changelog is correctly generated and that it includes the intended changes.

555-596: The _genchanges task has been further updated. This task now includes logic to handle cases where the changelog is being generated for a release. Ensure that this logic correctly handles these cases and that the changelog is correctly generated.

sickchill/gui/slick/css/style.css (9)

11-12: The changes to the .fa class might affect all elements using this class. Ensure that these changes do not unintentionally affect other elements.

43-46: The .ui-dialog .ui-resizable-se class has a background-position property without a background-image. This could lead to unexpected behavior. If there is a background-image defined in a parent class, it will be used. If not, this property will have no effect.

157-168: The .ui-tabs class and its child classes have been updated. Ensure that these changes do not unintentionally affect other elements using these classes.

215-221: The [class^="menu-icon-"], [class*=" menu-icon-"] selector targets classes that start with menu-icon- and classes that contain menu-icon-. Ensure that these changes do not unintentionally affect other elements using these classes.

388-390: The .footer class has been updated. Ensure that these changes do not unintentionally affect other elements using this class.

423-432: The .imgbanner .banner class has been updated. Ensure that these changes do not unintentionally affect other elements using this class.

1040-1043: The #checkboxControls span class has been updated. Ensure that these changes do not unintentionally affect other elements using this class.

1274-1277: The .showLegend, .movieLegend classes have been updated. Ensure that these changes do not unintentionally affect other elements using these classes.

1427-1429: The .listing-key class has been updated. Ensure that these changes do not unintentionally affect other elements using this class.

.github/workflows/check_release.yml

.github/workflows/upgrade_dependencies.yml

debian/changelog

sickchill/gui/slick/css/style.css

BKSteve · 2023-11-03T17:10:25Z

@miigotu damn that threw a whole bunch of semicolons.

miigotu · 2023-11-03T17:24:51Z

@BKSteve coderabbit is opinionated, and in beta. The semicolons are part of our code style. Also, we can't use the automatic commits suggested by it, because they will not take white space into account and a bad commit gets made.

coderabbitai

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 102c152 and cc9cd85.

Files selected for processing (1)

sickchill/gui/slick/views/config_providers.mako (1 hunks)

Files skipped from review due to trivial changes (1)

sickchill/gui/slick/views/config_providers.mako

github-advanced-security bot found potential problems Nov 3, 2023

View reviewed changes

coderabbitai bot reviewed Nov 3, 2023

View reviewed changes

miigotu changed the base branch from master to develop November 3, 2023 17:18

BKSteve enabled auto-merge (squash) November 3, 2023 17:24

miigotu disabled auto-merge November 3, 2023 17:25

miigotu enabled auto-merge (squash) November 3, 2023 17:25

miigotu approved these changes Nov 3, 2023

View reviewed changes

Update config_providers.mako

cc9cd85

miigotu force-pushed the BKSteve-patch-1 branch from 313d393 to cc9cd85 Compare November 3, 2023 23:07

coderabbitai bot reviewed Nov 3, 2023

View reviewed changes

miigotu disabled auto-merge November 3, 2023 23:10

miigotu merged commit b116251 into develop Nov 3, 2023
1 check passed

miigotu deleted the BKSteve-patch-1 branch November 3, 2023 23:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bk steve patch 1 #8610

Bk steve patch 1 #8610

BKSteve commented Nov 3, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 3, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

coderabbitai bot left a comment

BKSteve commented Nov 3, 2023

miigotu commented Nov 3, 2023

coderabbitai bot left a comment

Bk steve patch 1 #8610

Bk steve patch 1 #8610

Conversation

BKSteve commented Nov 3, 2023 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Nov 3, 2023 • edited Loading

Walkthrough

Changes

Chat with CodeRabbit Bot (@coderabbitai)

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

coderabbitai bot left a comment

Choose a reason for hiding this comment

BKSteve commented Nov 3, 2023

miigotu commented Nov 3, 2023

coderabbitai bot left a comment

Choose a reason for hiding this comment

BKSteve commented Nov 3, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 3, 2023 •

edited

Loading

Chat with CodeRabbit Bot (`@coderabbitai`)

CodeRabbit Configration File (`.coderabbit.yaml`)