chore: clean up formatting

[miigotu]

Summary by CodeRabbit

• Refactor
  • Improved code readability by renaming variables and methods across multiple files.
• New Features
  • Introduced new methods for error handling and URL processing.
• Bug Fixes
  • Updated database connection retrieval method to ensure stable operation.
• Chores
  • Updated build and release process for better project management.

[coderabbitai]

Walkthrough

The changes primarily revolve around code refactoring and exception handling in the SickChill project. Key modifications include renaming of methods and variables for better readability, updating method calls, and adding new methods. Additionally, the Gruntfile.js has been updated to enhance the build and release process.

Changes

File	Summary
Gruntfile.js	Task configurations, task registration, and command execution have been updated. Changes to the generation of a changelog file and the handling of version numbers have been made.
sickchill/oldbeard/.../binsearch.py	The update_cache method has been modified to use a different method for retrieving a database connection.
sickchill/oldbeard/tvcache.py	Several methods have been renamed and updated to call the new method names. New parameters have been added to the search_cache and find_needed_episodes methods.
sickchill/providers/GenericProvider.py	Variables and methods have been renamed for better readability. New methods have been added, and exception handling has been introduced in certain methods.

🍂 As autumn leaves fall, we refactor with glee, 🍁

Code now more readable, as clear as can be. 📖

With each method renamed, and each exception caught, 🐞

Our project evolves, with the changes we've wrought. 🛠️

So here's to the coders, in their digital den, 🐇

Making SickChill better, again and again. 🔄

As the season changes, so does our code, 🔄

In the grand scheme of things, it's just another node. 💻

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai help to get help.
• @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 102c152 and 9f18d56.

Files selected for processing (4)

• Gruntfile.js (8 hunks)
• sickchill/oldbeard/providers/binsearch.py (1 hunks)
• sickchill/oldbeard/tvcache.py (11 hunks)
• sickchill/providers/GenericProvider.py (7 hunks)

Additional comments: 26

sickchill/oldbeard/providers/binsearch.py (1)

• 91-96: The change from self._get_db() to self.get_db() indicates that the method for retrieving a database connection has been updated. Ensure that the new get_db() method is correctly implemented and returns the expected database connection. Also, verify that the mass_upsert method is correctly handling the data in cl.

sickchill/providers/GenericProvider.py (7)

• 183-189: The variable names have been improved for better readability. The variable cl has been renamed to cache_list and ci to cache_item. This is a good practice as it makes the code more understandable.

• 264-273: The method cache._add_cache_entry() has been renamed to cache.add_cache_entry(). Ensure that all calls to this function throughout the codebase have been updated to match the new method name.

• 314-322: The method cache._get_db() has been replaced with cache.get_db(). Ensure that all calls to this function throughout the codebase have been updated to match the new method name.

• 336-342: A new method get_url_hook() has been added with a static method decorator. This method seems to be used as a hook for HTTP responses. Ensure that this method is being used correctly wherever it's needed.

• 499-505: A try-except block has been added in the method hash_from_magnet() to catch exceptions. This is a good practice as it prevents the program from crashing in case of an error.

• 523-529: A try-except block has been added in the method _make_url() to catch exceptions. This is a good practice as it prevents the program from crashing in case of an error.

• 586-592: A new method check_set_option() has been added. This method seems to be used for checking and setting options based on HTTP request methods. Ensure that this method is being used correctly wherever it's needed.

Gruntfile.js (7)

• 1-6: The use of 'use strict' and the module.exports function is standard for Node.js and Gruntfile.js. No issues here.

• 9-13: The 'default' task is registered with a list of tasks to run. Ensure that all these tasks are defined and working as expected.

• 25-143: > Note: This review was outside of the patch, so it was mapped to the patch with the greatest overlap. Original lines [15-53]

The 'publish' task is registered with a list of tasks to run. Ensure that all these tasks are defined and working as expected. Also, ensure that the 'publish' task is only run by administrators as indicated by the comment.

• 55-57: The 'genchanges' task is registered with a list of tasks to run. Ensure that all these tasks are defined and working as expected.

• 59-78: The 'reset_publishing' task is registered with a list of tasks to run. Ensure that all these tasks are defined and working as expected. Also, ensure that the 'reset_publishing' task is not run in a CI environment as indicated by the if statement.

• 187-513: > Note: This review was outside of the patch, so it was mapped to the patch with the greatest overlap. Original lines [83-459]

The grunt.initConfig function is called with a configuration object. Ensure that all tasks are configured correctly and that all paths and options are valid.

• 521-612: > Note: This review was outside of the patch, so it was mapped to the patch with the greatest overlap. Original lines [464-611]

Several internal tasks are registered. Ensure that all these tasks are defined and working as expected. Also, ensure that these tasks are not run directly as indicated by the '(internal) do not run' comment.

sickchill/oldbeard/tvcache.py (11)

• 183-189: The method _get_db has been renamed to get_db. This change improves the consistency of the code, as the underscore prefix in Python is typically used to denote private methods or variables, but this method is used outside of its class.

• 192-196: The method _clear_cache now calls get_db instead of _get_db. This change is necessary due to the renaming of _get_db to get_db.

• 231-235: The method update_cache now calls get_db instead of _get_db. This change is necessary due to the renaming of _get_db to get_db.

• 263-266: The method _parse_item now calls add_cache_entry instead of _add_cache_entry. This change is necessary due to the renaming of _add_cache_entry to add_cache_entry.

• 274-278: The method last_update now calls get_db instead of _get_db. This change is necessary due to the renaming of _get_db to get_db.

• 288-292: The method last_search now calls get_db instead of _get_db. This change is necessary due to the renaming of _get_db to get_db.

• 307-311: The method set_last_update now calls get_db instead of _get_db. This change is necessary due to the renaming of _get_db to get_db.

• 319-323: The method set_last_search now calls get_db instead of _get_db. This change is necessary due to the renaming of _get_db to get_db.

• 340-343: The method _add_cache_entry has been renamed to add_cache_entry. This change improves the consistency of the code, as the underscore prefix in Python is typically used to denote private methods or variables, but this method is used outside of its class.

• 402-405: The method list_propers now calls get_db instead of _get_db. This change is necessary due to the renaming of _get_db to get_db.

• 426-429: The method find_needed_episodes now calls get_db instead of _get_db. This change is necessary due to the renaming of _get_db to get_db.