Maintain scheme when building the qBittorrent client

[xelgand]

Fixes #

Proposed changes in this pull request:

• Maintain the scheme when parsing the URL provided by the user.

• Only affects the qBittorrent client.

• PR is based on the DEVELOP branch

• Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review

• Read contribution guide

Summary by CodeRabbit

• Refactor
  • Updated the qBittorrent client initialization to use the full URL for enhanced connectivity and added logging for the qBittorrent URL.

[coderabbitai]

Walkthrough

The recent update involves enhancing the Client class within the qbittorrent.py file. The primary modification is the shift from utilizing just the hostname to employing the full URL for initialization. Additionally, the update introduces logging of the qBittorrent URL, aiming to refine the integration and debugging process by providing more detailed connection insights.

Changes

File	Summary
sickchill/oldbeard/clients/qbittorrent.py	Updated Client class to use full URL instead of just the hostname; added qBittorrent URL logging.

🐇✨
In the land of code, where the bits do roam,
A rabbit hopped in, making this its home.
With a tweak and a hop, it refined the way,
Now URLs shine, clear as day.
"To the future," it thumps, with a bright, keen eye,
"Let our connections, like stars, light the sky!"
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 110b5b4 and 110b5b9.

Files selected for processing (1)

• sickchill/oldbeard/clients/qbittorrent.py (1 hunks)

Additional comments: 2

sickchill/oldbeard/clients/qbittorrent.py (2)

• 19-19: Logging the full qBittorrent URL can potentially expose sensitive information in logs. Consider sanitizing the URL to remove any credentials before logging or ensure that this logging level is used with caution in environments where logs might be exposed.
• 21-21: Ensure that the qbittorrentapi.Client supports the full URL, including the scheme, in the host parameter. This change aligns with the objective of preserving the URL scheme but requires confirmation of compatibility with the qBittorrent API client.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 110b5b9 and e3f1f55.

Files selected for processing (1)

• sickchill/oldbeard/clients/qbittorrent.py (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• sickchill/oldbeard/clients/qbittorrent.py