Refactored property parsing #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed `Header` to `ItemHeader` and `Properties` to `ItemProperties` for better code clarity and maintainability. Updated corresponding method signatures, variable names, and related logic across the codebase to reflect these changes. Introduced `PropertyDefinition` to standardize property parsing logic.
Replaced manual property filter logic with a modular approach using new `PropertyParser` and filter components for better maintainability. Removed outdated filter management code and introduced components for double and int property filters. Streamlined property handling in `TradeFilterService` and improved flexibility for parsing trade requests."
domialex
reviewed
Jan 4, 2025
src/Sidekick.Apis.Poe/Parser/Properties/Definitions/AreaLevelProperty.cs
Outdated
Show resolved
Hide resolved
domialex
reviewed
Jan 4, 2025
src/Sidekick.Apis.Poe/Parser/Properties/Definitions/CrusaderProperty.cs
Outdated
Show resolved
Hide resolved
Updated property filters and trade request logic to better handle Path of Exile 2 (PoE2). Introduced game-specific handling for filters and unified initialization patterns across filters. Enhanced flexibility and maintainability of trade request preparation.
The `ShowCheckbox` property was unused and has been removed to simplify the codebase. This change affects multiple property definitions and filters, ensuring consistency across the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283
Fixes #415
Fixes #453