Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check to make sure tokens can't call lock recursively #3315

Open
wants to merge 10 commits into
base: future/peggy2
Choose a base branch
from
Open

Add a check to make sure tokens can't call lock recursively #3315

wants to merge 10 commits into from

Conversation

banshee
Copy link
Contributor

@banshee banshee commented Oct 10, 2022

Fixes #3309

@banshee banshee marked this pull request as ready for review October 10, 2022 22:54
@banshee banshee self-assigned this Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022 •
edited
Loading

Codecov Report

Merging #3315 (22e0ed0) into future/peggy2 (ef044b7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           future/peggy2    #3315      +/-   ##
=================================================
- Coverage          47.96%   47.95%   -0.01%     
=================================================
  Files                169      169              
  Lines              15024    15027       +3     
=================================================
  Hits                7206     7206              
- Misses              7385     7388       +3     
  Partials             433      433
Impacted Files Coverage Δ
cmd/ebrelayer/relayer/ethereum.go 1.37% <0.00%> (-0.02%) ⬇️

Brando753
Brando753 suggested changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@Brando753 Brando753 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, will probably do them myself.

cmd/ebrelayer/relayer/ethereum.go Show resolved Hide resolved
smart-contracts/contracts/BridgeBank/BridgeBank.sol Outdated Show resolved Hide resolved
smart-contracts/contracts/BridgeBank/BridgeBank.sol Outdated Show resolved Hide resolved
@banshee banshee added Peggy 2.0 An issue blocking the Peggy 2.0 release Peggy Team Peggy team task labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brando753 Brando753 Brando753 requested changes

@smartyalgo smartyalgo Awaiting requested review from smartyalgo

Assignees

@banshee banshee

Labels
Peggy Team Peggy team task Peggy 2.0 An issue blocking the Peggy 2.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banshee @Brando753